1 |
On Tuesday 31 May 2011 00:38:34 Brian Harring wrote: |
2 |
> On Tue, May 31, 2011 at 12:05:03AM +0200, Andreas K. Huettel wrote: |
3 |
> > Am Montag 30 Mai 2011, 23:55:52 schrieb Brian Harring: |
4 |
> > > If someone has a definition that is commonsense, then propose it- the |
5 |
> > > current "you must log everything" is very, very heavy handed and |
6 |
> > > basically was a forced situation since QA cannot make folks behave |
7 |
> > > when the rules are reliant on common sense. |
8 |
> > |
9 |
> > Well how about "any change that can influence the behaviour of |
10 |
> > (portage|your favourite package manager) in any way or present the user |
11 |
> > with different output"? |
12 |
> |
13 |
> Mostly correct, although the problem there is 'influence'; consider: |
14 |
> |
15 |
> src_unpack() { |
16 |
> bunch of code |
17 |
> } |
18 |
> |
19 |
> being changed into |
20 |
> |
21 |
> new_func() { |
22 |
> bunch of code |
23 |
> } |
24 |
> src_unpack() { |
25 |
> invoke new_func |
26 |
> } |
27 |
> |
28 |
> That should have no influence, thus not being ChangeLog'd. The |
29 |
> problem is when the dev screws up, and it *has* an influence but no |
30 |
> ChangeLog. |
31 |
> |
32 |
> A more real world example is people abusing eval and other things |
33 |
> (python eclass for example)- folks can/do argue that it has no |
34 |
> influence, but the complexity means it may have unexpected affect. |
35 |
> |
36 |
> That's the crux of the issue, and it comes down to common sense. |
37 |
> Come up w/ a sane policy for things like that and I'll owe you some |
38 |
> beer. |
39 |
> |
40 |
> Either way, for the rest of it, as Diego said, LGTM. I'm just |
41 |
> nitpicking here to make it absolutely clear to people where we start |
42 |
> running into policy issues. |
43 |
> |
44 |
> ~brian |
45 |
|
46 |
Not disagreeing at all with what was said, I'm just going to add that adding |
47 |
conditionals or exceptions to the rules makes them harder to remember. It is |
48 |
easier to remember - you shall not pass - than - you shall not pass if you |
49 |
make a change wich does not affect X - . |
50 |
|
51 |
Regards, |
52 |
-- |
53 |
Angelo Arrifano AKA MiKNiX |
54 |
Gentoo Embedded developer |
55 |
GPE maintainer |
56 |
http://www.gentoo.org/~miknix |
57 |
http://miknix.homelinux.com |