Gentoo Archives: gentoo-dev

From: Fabian Groffen <grobian@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-admin/chrpath: ChangeLog chrpath-0.13-r2.ebuild
Date: Tue, 11 Oct 2011 18:14:43
Message-Id: 20111011181358.GW704@gentoo.org
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-admin/chrpath: ChangeLog chrpath-0.13-r2.ebuild by Samuli Suominen
1 On 11-10-2011 21:01:40 +0300, Samuli Suominen wrote:
2 > On 10/11/2011 08:05 PM, Fabian Groffen wrote:
3 > > On 11-10-2011 19:59:13 +0300, Samuli Suominen wrote:
4 > >> So I've missed one ${EPREFIX} for docdir= ? How about just fixing that,
5 > >> and not crapping all over the package?
6 > >
7 > > How about first asking the maintainer before you completely rewrite an
8 > > ebuild? I'm not innocent on this topic either (ask Diego for example),
9 > > and I do allow you to make a lot of changes to my packages. Just don't
10 > > force your style and preferences on me.
11 >
12 > So basically you are saying you reverted tehnically correct changes for
13 > cosmetics. What ticked you off, the \ lines changes? I believe that was
14 > the only change that wasn't about fixing something broken.
15
16 No, you broke the package for Prefix. Next you bumped it to EAPI=4,
17 then you removed SRC_URI for no particular reason, dropped libtool files
18 and dropped static archives. Next to this you did some reordering and
19 other cosmetic changes.
20
21 > And so have you, changed dozens of my ebuilds for PREFIX compability or
22 > other random fixes, not everything turned out correct, mistakes were
23 > made and were clearly accidental. I've fixed them instead of wasting
24 > both of our times. Is it too much to ask for same in return?
25
26 I already told you that you can change quite a lot to my ebuilds,
27 without me complaining. Do you mind me reverting your stuff and redoing
28 it now?
29
30
31 --
32 Fabian Groffen
33 Gentoo on a different level

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies