Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Jeroen Roovers <jer@g.o>
Subject: Re: Re: [gentoo-commits] gentoo-x86 commit in app-misc/linux-logo: linux-logo-5.11.ebuild ChangeLog
Date: Fri, 24 Jun 2011 18:22:17 +0200
On Fri, 24 Jun 2011 10:29:51 +0400
Peter Volkov <pva@g.o> wrote:

> > src_prepare() {
> > 	echo "./logos/gentoo.logo" >> logo_config
> > 	echo "./logos/gentoo2.logo" >> logo_config
> > 	echo "./logos/banner-simplified.logo" >> logo_config
> > 	echo "./logos/banner.logo" >> logo_config
> > 	echo "./logos/classic-no_periods.logo" >> logo_config
> > 	echo "./logos/classic-no_periods_or_chars.logo" >>
> > logo_config echo "./logos/classic.logo" >> logo_config
> 
> cat >> logo_config <<-EOF will look much better here.

src_prepare() {
    cat >> logo_config <<EOF
line0
line1
line2
line3
EOF
}

Since I like indenting, I don't think so. Using FILESDIR is probably
better, as mgorny suggested.

> 
> > 	cp "${FILESDIR}"/gentoo{,2}.logo "${S}"/logos/
> 
> || die


Good catch.

> > 	echo "NAME gentoo" >> "${S}"/logos/gentoo.logo
> > }
> > 
> > src_compile() {
> > 	ARCH="" ./configure --prefix="${D}"/usr || die
> 
> Why not src_configure()?
> Also use econf or add # some comment here, please.

Legacy.

> > 	cp "${FILESDIR}"/${PN}.conf "${WORKDIR}"
> > 	sed -i -e 's/-L 4 -f -u/-f -u/' "${WORKDIR}"/${PN}.conf
> 
> || die

Yes.


     jer


Replies:
Re: Re: [gentoo-commits] gentoo-x86 commit in app-misc/linux-logo: linux-logo-5.11.ebuild ChangeLog
-- Peter Volkov
References:
Re: [gentoo-commits] gentoo-x86 commit in app-misc/linux-logo: linux-logo-5.11.ebuild ChangeLog
-- Peter Volkov
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: Re: [gentoo-commits] gentoo-x86 commit in app-misc/linux-logo: linux-logo-5.11.ebuild ChangeLog
Next by thread:
Re: Re: [gentoo-commits] gentoo-x86 commit in app-misc/linux-logo: linux-logo-5.11.ebuild ChangeLog
Previous by date:
Re: Tags (Was: RFC: split up media-sound/ category)
Next by date:
Re: Re: [gentoo-commits] gentoo-x86 commit in app-misc/linux-logo: linux-logo-5.11.ebuild ChangeLog


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.