| 1 |
On 06/02/2012 12:49 AM, Mike Frysinger wrote: |
| 2 |
> On Wednesday 23 May 2012 21:04:42 hasufell wrote: |
| 3 |
>> # @FUNCTION: _iconins |
| 4 |
>> # @DESCRIPTION: |
| 5 |
>> # function for use in doicon and newicon |
| 6 |
> |
| 7 |
> mark it @INTERNAL |
| 8 |
> |
| 9 |
>> if [[ -z $size ]] ; then |
| 10 |
> |
| 11 |
> ${size} |
| 12 |
> |
| 13 |
>> if [[ $function == doicon ]] ; then |
| 14 |
> |
| 15 |
> ${function} |
| 16 |
> |
| 17 |
>> if [[ $function == newicon ]] ; then |
| 18 |
> |
| 19 |
> ${function} |
| 20 |
> |
| 21 |
>> doicon() { |
| 22 |
>> local function=$FUNCNAME |
| 23 |
>> _iconins "$@" |
| 24 |
> |
| 25 |
> passing the funcname in this way is kind of ugly. you could do: |
| 26 |
> _iconins ${FUNCNAME} "$@" |
| 27 |
> |
| 28 |
> and then at the top of _iconins: |
| 29 |
> local funcname=$1; shift |
| 30 |
> |
| 31 |
> i guess if we all agree this complication is useful, then fix the nits and |
| 32 |
> let's merge it |
| 33 |
> -mike |
| 34 |
|
| 35 |
|
| 36 |
Yo, I hope this is it. |
| 37 |
|
| 38 |
Haven't seen many arguments against it as it is an optional feature anyway. |
| 39 |
|
| 40 |
Anyone got reservations left? |
Archives