| 1 |
On 04/15/12 16:16, Ryan Hill wrote: |
| 2 |
> Right now we have support in some packages for user patches - those being |
| 3 |
> patches dropped into /etc/portage/patches/pkgname/ - which are automatically |
| 4 |
> applied. Because this feature is implemented by epatch_user() in |
| 5 |
> eutils.eclass, it is only available for ebuilds that inherit eutils and |
| 6 |
> explicitly call epatch_user or inherit another eclass that calls it in an |
| 7 |
> exported phase (eg. base). The end result is a very inconsistent experience, |
| 8 |
> where user patches may or may not work not only on a package-by-package |
| 9 |
> basis, but ebuild-by-ebuild. |
| 10 |
> |
| 11 |
> Is there any reason why this couldn't just be done in the package manager, |
| 12 |
> making user patches available for all ebuilds without code changes? |
| 13 |
> |
| 14 |
|
| 15 |
From a debugging / bug wrangling perspective it's bad because there's no |
| 16 |
way for me to see if someone accidentally patched in something |
| 17 |
unexpected. (And we do have creative users :) ) |
| 18 |
|
| 19 |
It's a neat feature, but I'm moderately opposed to it unless we can get |
| 20 |
reporting in place so I can definitely see (e.g. from a logfile or error |
| 21 |
message) that there's been some ebuild modifications. |
Archives