Gentoo Archives: gentoo-dev

From: Steven J Long <slong@××××××××××××××××××.uk>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in app-admin/chrpath: ChangeLog chrpath-0.13-r2.ebuild
Date: Wed, 12 Oct 2011 03:27:59
Message-Id: j731dv$3at$1@dough.gmane.org
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-admin/chrpath: ChangeLog chrpath-0.13-r2.ebuild by "Michał Górny"
1 Michał Górny wrote:
2 > I don't think that passing multiple files to epatch actually improves
3 > readability. Simple example:
4 >
5 > # bug #123456, foo, bar
6 > epatch "${FILESDIR}"/${P}-foo.patch
7 > # bug #234567, baz bazinga blah blah
8 > epatch "${FILESDIR}"/${P}-baz.patch
9 >
10 > With multiple arguments, you can't put comments in the middle.
11 >
12 ++ It's also a lot easier to remove the single patches when they're no
13 longer needed. In the context of configuring, building and installing a
14 package, the extra overhead is miniscule, whereas the above is *much*
15 easier to maintain.
16 --
17 #friendly-coders -- We're friendly, but we're not /that/ friendly ;-)

Replies