Gentoo Archives: gentoo-dev

From: Fabian Groffen <grobian@g.o>
To: gentoo-dev@l.g.o, Arfrever Frehtes Taifersar Arahesis <arfrever.fta@×××××.com>
Subject: [gentoo-dev] Re: proj/portage:master commit in: pym/portage/dbapi/
Date: Sat, 26 Nov 2011 10:59:05
Message-Id: 20111126105822.GA37825@gentoo.org
1 Attempt 2 from correct email address, sorry for any duplicate in
2 advance.
3
4 On 26-11-2011 01:54:35 +0000, Arfrever Frehtes Taifersar Arahesis wrote:
5 > commit: 1d4ac47c28706094230cb2c4e6ee1c1c71629aa0
6 > T> Org>
7 > AuthorDate: Sat Nov 26 01:52:49 2011 +0000
8 > Commit: Arfrever Frehtes Taifersar Arahesis <arfrever <AT> gentoo <DOT> org>
9 > CommitDate: Sat Nov 26 01:52:49 2011 +0000
10 > URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=1d4ac47c
11 >
12 > dblink.mergeme(): Merge files in alphabetic order.
13
14 What's the advantage of this? I don't really like to pay for sorting a
15 potentially huge list just for some eye-candy. (That's omitted by
16 default these days anyway...)
17 Any other opinions on this one?
18
19 > ---
20 > pym/portage/dbapi/vartree.py | 2 +-
21 > 1 files changed, 1 insertions(+), 1 deletions(-)
22 >
23 > diff --git a/pym/portage/dbapi/vartree.py b/pym/portage/dbapi/vartree.py
24 > index dd74c10..099164a 100644
25 > --- a/pym/portage/dbapi/vartree.py
26 > +++ b/pym/portage/dbapi/vartree.py
27 > @@ -3981,7 +3981,7 @@ class dblink(object):
28 > mergelist = stufftomerge
29 > offset = ""
30 >
31 > - for i, x in enumerate(mergelist):
32 > + for i, x in enumerate(sorted(mergelist)):
33 >
34 > mysrc = join(srcroot, offset, x)
35 > mydest = join(destroot, offset, x)
36 >
37
38 --
39 Fabian Groffen
40 Gentoo on a different level

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] Re: proj/portage:master commit in: pym/portage/dbapi/ Nirbheek Chauhan <nirbheek@g.o>
[gentoo-dev] Re: proj/portage:master commit in: pym/portage/dbapi/ Arfrever Frehtes Taifersar Arahesis <arfrever@g.o>