Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o, Arfrever Frehtes Taifersar Arahesis <arfrever.fta@...>
From: Fabian Groffen <grobian@g.o>
Subject: Re: proj/portage:master commit in: pym/portage/dbapi/
Date: Sat, 26 Nov 2011 11:58:22 +0100
Attempt 2 from correct email address, sorry for any duplicate in
advance.

On 26-11-2011 01:54:35 +0000, Arfrever Frehtes Taifersar Arahesis wrote:
> commit:     1d4ac47c28706094230cb2c4e6ee1c1c71629aa0
> T> Org>
> AuthorDate: Sat Nov 26 01:52:49 2011 +0000
> Commit:     Arfrever Frehtes Taifersar Arahesis <arfrever <AT> gentoo <DOT> org>
> CommitDate: Sat Nov 26 01:52:49 2011 +0000
> URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=1d4ac47c
> 
> dblink.mergeme(): Merge files in alphabetic order.

What's the advantage of this?  I don't really like to pay for sorting a
potentially huge list just for some eye-candy.  (That's omitted by
default these days anyway...)
Any other opinions on this one?

> ---
>  pym/portage/dbapi/vartree.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/pym/portage/dbapi/vartree.py b/pym/portage/dbapi/vartree.py
> index dd74c10..099164a 100644
> --- a/pym/portage/dbapi/vartree.py
> +++ b/pym/portage/dbapi/vartree.py
> @@ -3981,7 +3981,7 @@ class dblink(object):
>  			mergelist = stufftomerge
>  			offset = ""
>  
> -		for i, x in enumerate(mergelist):
> +		for i, x in enumerate(sorted(mergelist)):
>  
>  			mysrc = join(srcroot, offset, x)
>  			mydest = join(destroot, offset, x)
> 

-- 
Fabian Groffen
Gentoo on a different level
Attachment:
signature.asc (Digital signature)
Replies:
Re: proj/portage:master commit in: pym/portage/dbapi/
-- Arfrever Frehtes Taifersar Arahesis
Re: Re: proj/portage:master commit in: pym/portage/dbapi/
-- Nirbheek Chauhan
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
repoman not complaining when going straight to stable
Next by thread:
Re: Re: proj/portage:master commit in: pym/portage/dbapi/
Previous by date:
Re: repoman not complaining when going straight to stable
Next by date:
Re: Re: proj/portage:master commit in: pym/portage/dbapi/


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.