| 1 |
On 02/07/2010 01:10 PM, Stelian Ionescu wrote: |
| 2 |
> Wouldn't it be a good idea to use "set -e" in the ebuild environment ? |
| 3 |
> I've seen cases of ebuilds calling epatch without inheriting from eutils |
| 4 |
> which compiled and installed (apparently) fine but possibly broken |
| 5 |
> binaries. Examples of cases where "set -e" would have helped: 303849, |
| 6 |
> 297063, 260279, 221257, |
| 7 |
> https://bugs.gentoo.org/buglist.cgi?quicksearch=command+not+found |
| 8 |
> and perhaps others I haven't managed to find in bugzilla |
| 9 |
|
| 10 |
I don't know what kind of side-effects set -e would introduce, but |
| 11 |
we can easily add a repoman check for epatch calls without eutils |
| 12 |
inherit. |
| 13 |
|
| 14 |
Portage already does a search of the build log for 'command not |
| 15 |
found' messages and generates a QA warnings. Set |
| 16 |
PORTAGE_ELOG_CLASSES="${PORTAGE_ELOG_CLASSES} qa" in /etc/make.conf |
| 17 |
if you want to have those warnings logged. |
| 18 |
-- |
| 19 |
Thanks, |
| 20 |
Zac |
Archives