On 23:52 Tue 25 Nov     , Peter Alfredsen (loki_val) wrote:
> loki_val    08/11/25 23:52:04
> 
>   Added:                gtk-sharp-module.eclass
>   Log:
>   eclass required for gnome-sharp and gnome-desktop-sharp packages

Did I miss this on gentoo-dev? All eclasses must be sent there for 
review before addition to the tree.

> if [[ " ${gtk_sharp_module_list} " == *" ${GTK_SHARP_MODULE} "* ]] ; then
> 	my_module_list="${gtk_sharp_module_list}"
> 	my_tarball="gtk-sharp"
> elif [[ " ${gnome_sharp_module_list} " == *" ${GTK_SHARP_MODULE} "* ]] ; then

This seems like a really strange strategy for checking whether a certain 
item is in a list.

> 	# Make selecting components configurable.
> 	epatch ${WORKDIR}/${MY_P}-configurable.diff

This seems like something you might want optional, depending on some 
variable.

> 	# Fixes support with pkgconfig-0.17, #92503.
> 	sed -i -e 's/\<PKG_PATH\>/GTK_SHARP_PKG_PATH/g' \
> 			-e ':^CFLAGS=:d' \
> 			${S}/configure.in

It would be nice to quote all instances of $S, $D etc.

> 	LANG=C emake -j1 || die "emake failed"

Worth a comment about parallel make being broken, with a reference to 
the upstream bug.

-- 
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com