Archives
Archives
| From: | Mike Frysinger <vapier@g.o> | ||
|---|---|---|---|
| To: | Sergei Trofimovich <slyfox@g.o> | ||
| Cc: | gentoo-dev@l.g.o, bronksos@×××××.com | ||
| Subject: | Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2) | ||
| Date: | Tue, 29 Jun 2010 18:57:03 | ||
| Message-Id: | 201006291455.53671.vapier@gentoo.org | ||
| In Reply to: | Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2) by Sergei Trofimovich |
||
| 1 | > return 0 |
| 2 | |
| 3 | nowhere do you check the return value of xmms2_flag, so not much point in |
| 4 | returning a value (also, the eerror path no longer returns 1) |
| 5 | |
| 6 | > ${CHOST:+--with-target-platform=${CHOST}} \ |
| 7 | |
| 8 | CHOST is guaranteed to always be set, so no need for the ${VAR:+} magic |
| 9 | |
| 10 | > for option in "${option_map[@]}"; do |
| 11 | > for plugin in "${plugin_map[@]}"; do |
| 12 | |
| 13 | you didnt declare option/plugin local anywhere that i can see |
| 14 | -mike |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v3) | Sergei Trofimovich <slyfox@g.o> |