Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: Sergei Trofimovich <slyfox@g.o>
From: Mike Frysinger <vapier@g.o>
Subject: Re: RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2)
Date: Tue, 29 Jun 2010 14:55:52 -0400
>	return 0

nowhere do you check the return value of xmms2_flag, so not much point in 
returning a value (also, the eerror path no longer returns 1)

>			${CHOST:+--with-target-platform=${CHOST}} \

CHOST is guaranteed to always be set, so no need for the ${VAR:+} magic

>		for option in "${option_map[@]}"; do
>		for plugin in "${plugin_map[@]}"; do

you didnt declare option/plugin local anywhere that i can see
-mike
Attachment:
signature.asc (This is a digitally signed message part.)
References:
RFC: media-sound/xmms2/xmms2-0.7.ebuild
-- Sergei Trofimovich
Re: RFC: media-sound/xmms2/xmms2-0.7.ebuild
-- Mike Frysinger
Re: RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2)
-- Sergei Trofimovich
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2)
Next by thread:
Re: RFC: media-sound/xmms2/xmms2-0.7.ebuild (v3)
Previous by date:
Re: Adding --as-needed to LDFLAGS in profiles/default/linux/make.defaults
Next by date:
Re: RFC: media-sound/xmms2/xmms2-0.7.ebuild (v3)


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.