Gentoo Archives: gentoo-dev

From: justin <jlec@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] recent change in wxwidgets.eclass potentially breaks packages
Date: Sun, 17 Jul 2011 09:20:11
Message-Id: 4E22A923.4000003@gentoo.org
In Reply to: Re: [gentoo-dev] recent change in wxwidgets.eclass potentially breaks packages by "Michał Górny"
1 On 17/07/11 11:16, Michał Górny wrote:
2 > On Sun, 17 Jul 2011 11:05:39 +0200
3 > justin <jlec@g.o> wrote:
4 >
5 >> Hi all,
6 >>
7 >> the following change has some bad effects on packages in the tree. I
8 >> found it with a package having this inherit line
9 >>
10 >> inherit cmake-utils wxwidgets
11 >>
12 >> all cmake-utils_* function which have redundant phase definitions in
13 >> base will not be executed.
14 >>
15 >> This change was not trivial. So either we need to revert it or really
16 >> check the tree that nothing is broken.
17 >
18 > Revert. The wxwidgets eclass is not really supposed to export phase
19 > functions, I've seen packages in Sunrise using it along with
20 > cmake-utils too. If someone wants user patches in their package, he/she
21 > should inherit base directly and get phase funcs clean.
22 >
23
24 So I checked it. There are a couple of packages which use it in
25 combination with cmake-utils, python and autotools-utils. And as
26 maintainer keeps the lines sorted, all those ebuilds are broken potentially.

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies