1 |
On Wed, 17 Feb 2010 18:11:42 +0000, Ciaran McCreesh |
2 |
<ciaran.mccreesh@××××××××××.com> wrote: |
3 |
> On Wed, 17 Feb 2010 18:03:42 +0000 |
4 |
> Jeremy Olexa <darkside@g.o> wrote: |
5 |
>> What is going on with all these undocumented changes? When I look at |
6 |
>> the council logs to see what is in EAPI3, I don't see anything about |
7 |
>> removing functions. This is just silly and wastes alot of people's |
8 |
>> time for no practical gain. |
9 |
> |
10 |
> Being in eutils, none of this has anything to do with PMS or the |
11 |
> Council. |
12 |
|
13 |
So, I was highlighting a problem. No one wants to write docs, which is |
14 |
quite bad for the health of Gentoo. |
15 |
|
16 |
> |
17 |
>> In my EAPI3 portage, bin/isolated-functions.sh still has eqawarn() |
18 |
>> defined. So, what am I missing now? |
19 |
> |
20 |
> eqawarn has never been defined in any EAPI. It's a Portage internal, |
21 |
> not something for ebuilds to use. If you'd like it to be in an EAPI, you |
22 |
> can propose it for EAPI 5. |
23 |
|
24 |
Yes, correct. For some reason, I thought it was valid to use eqawarn in |
25 |
ebuilds. Now I guess a valid fix for eutils.eclass would be: |
26 |
|
27 |
%% cvs di eutils.eclass |
28 |
Index: eutils.eclass |
29 |
=================================================================== |
30 |
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v |
31 |
retrieving revision 1.333 |
32 |
diff -u -r1.333 eutils.eclass |
33 |
--- eutils.eclass 17 Feb 2010 17:10:23 -0000 1.333 |
34 |
+++ eutils.eclass 17 Feb 2010 18:20:18 -0000 |
35 |
@@ -54,13 +54,11 @@ |
36 |
else |
37 |
|
38 |
ebeep() { |
39 |
- [[ $(type -t eqawarn) == function ]] && \ |
40 |
- eqawarn "QA Notice: ebeep is not defined in EAPI=3, please |
41 |
file a bug at http://bugs.gentoo.org" |
42 |
+ einfo "QA Notice: ebeep is not defined in EAPI=3, please |
43 |
file a bug at http://bugs.gentoo.org" |
44 |
} |
45 |
|
46 |
epause() { |
47 |
- [[ $(type -t eqawarn) == function ]] && \ |
48 |
- eqawarn "QA Notice: epause is not defined in EAPI=3, |
49 |
please file a bug at http://bugs.gentoo.org" |
50 |
+ einfo "QA Notice: epause is not defined in EAPI=3, please |
51 |
file a bug at http://bugs.gentoo.org" |
52 |
} |
53 |
|
54 |
fi |
55 |
|
56 |
(where einfo is used because it doesn't need to be logged) |
57 |
|
58 |
-Jeremy |