1 |
On 15/03/11 23:06, Mike Frysinger wrote: |
2 |
>> # Copyright 1999-2004 Gentoo Foundation |
3 |
> |
4 |
> s/2004/2011/ |
5 |
> |
6 |
> have you looked at the man page output for this to make sure the white spacing |
7 |
> you're putting into the comments properly carries over ? |
8 |
|
9 |
I will do this before the final commit. Currently it is alright. |
10 |
|
11 |
> |
12 |
>> # @ECLASS-VARIABLE: EBO_DESCRIPTION |
13 |
>> # @DESCRIPTION: |
14 |
>> # Should be set. Completes the describtion of the embassy module as follows: |
15 |
> |
16 |
> i dont understand what this is trying to say (ignoring the spelling mistake in |
17 |
> description) |
18 |
|
19 |
These are all modules for EMBOSS. I want to shorten the Description of |
20 |
each ebuild to the important part. But I will makes this clearer for the |
21 |
manpage. What I don't want, is what you can read in all the gstreamer |
22 |
plugins "plugins for foo" |
23 |
|
24 |
>> HOMEPAGE="http://emboss.sourceforge.net" |
25 |
> |
26 |
> could do with a trailing "/" |
27 |
|
28 |
I asked myself quite often, if this needed or not. What is the purpose |
29 |
of the trailing "/"? |
30 |
|
31 |
// |
32 |
snip |
33 |
// |
34 |
|
35 |
>> # $(use_with png pngdriver "${EPREFIX}/usr") |
36 |
>> # $(use_with pdf hpdf "${EPREFIX}/usr") |
37 |
>> # $(use_with mysql mysql "${EPREFIX}/usr/bin/mysql_config") |
38 |
>> # $(use_with postgres postgresql "${EPREFIX}/usr/bin/pg_config") |
39 |
> |
40 |
> do you really need full paths here ? are the configure scripts that screwed |
41 |
> up ? ideally libs would be found via .pc files. |
42 |
|
43 |
It f..ing defaults to / roots if not specified |
44 |
|
45 |
> |
46 |
>> # $(use_enable amd64 64) |
47 |
> |
48 |
> oh god it burns so bad when i poo |
49 |
> |
50 |
>> emboss_src_install() { |
51 |
>> default |
52 |
>> mv "${ED}"/usr/share/EMBOSS/doc/* "${ED}"/usr/share/doc/${PF}/ |
53 |
>> rm -rf "${ED}"/usr/share/EMBOSS/doc |
54 |
> |
55 |
> does the configure script respect --docdir= ? then you wouldnt need this |
56 |
> clean up logic ... |
57 |
|
58 |
It soesn't and actually the java part (not installed yet) expects docs |
59 |
here. I am not sure where this could be left like this or breaks somehting. |
60 |
|
61 |
> -mike |
62 |
|
63 |
Thanks mike for all your suggestions and remarks. I will fix the eclass |
64 |
accordingly. |
65 |
|
66 |
justin |