Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: grobian@g.o
Subject: Re: [gentoo-dev] Re: RFC: leechcraft.eclass
Date: Thu, 18 Aug 2011 19:41:00
Message-Id: 20110818214147.294b340d@pomiocik.lan
In Reply to: Re: [gentoo-dev] Re: RFC: leechcraft.eclass by Fabian Groffen
1 On Thu, 18 Aug 2011 20:43:59 +0200
2 Fabian Groffen <grobian@g.o> wrote:
3
4 > On 18-08-2011 20:42:23 +0200, Michał Górny wrote:
5 > > > elif [[ ${PN} != "leechcraft-core" ]]; then
6 > > > CAKE_USE_DIR="${S}"/src/plugins/${PN#leechcraft-}
7 > >
8 > > Don't quote that. It looks bad that the left-side is unquoted and
9 > > right side is quoted.
10 >
11 > it's a string, what's the problem?
12
13 It's just a matter of taste. I think it looks better if both sides are
14 quoted, or neither is.
15
16 --
17 Best regards,
18 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] Re: RFC: leechcraft.eclass Ulrich Mueller <ulm@g.o>
Re: [gentoo-dev] Re: RFC: leechcraft.eclass Fabian Groffen <grobian@g.o>