1 |
2010-07-06 00:29:09 Mike Frysinger napisał(a): |
2 |
> On Monday, July 05, 2010 16:23:50 Arfrever Frehtes Taifersar Arahesis wrote: |
3 |
> > 2010-07-05 21:18:57 Mark Loeser napisał(a): |
4 |
> > > Arfrever Frehtes Taifersar Arahesis said: |
5 |
> > > > 2010-07-05 20:00:11 Mark Loeser napisał(a): |
6 |
> > > > > Everyone else has already made valid points. I'm just picking this |
7 |
> > > > > one to reply to now. Please remove the colors you have added. If |
8 |
> > > > > you need a new function, say "eqawarn", we should have that added in |
9 |
> > > > > the next EAPI with a description of when and where to use it. |
10 |
> > > > |
11 |
> > > > In case of the colored message added in this patch, if |
12 |
> > > > einfo/elog/ewarn/eqawarn/eerror was used, then its output wouldn't be |
13 |
> > > > logged by Portage. |
14 |
> > > |
15 |
> > > I don't understand what you are trying to say. |
16 |
> > |
17 |
> > Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in |
18 |
> > global scope. |
19 |
> |
20 |
> dont call it in global scope then. the more parsing you do in global scope |
21 |
> the worse you make performance for the tree. these things get executed during |
22 |
> dependency generation which means it gets spammed even when not emerging. |
23 |
> |
24 |
> use pkg_setup or something similar like everyone else. |
25 |
|
26 |
Only 84 ebuilds in the tree set NEED_PYTHON variable. NEED_PYTHON can be used only in EAPI <=2. |
27 |
python_pkg_setup() is optional in EAPI <=3. Exactly 0 ebuilds, which use NEED_PYTHON, also call |
28 |
python_pkg_setup(). EXPORT_FUNCTIONS wasn't ommitted during this calculation. |
29 |
|
30 |
There are over 27000 ebuilds in the tree. Performance penalty from <=84 ebuilds shouldn't be |
31 |
noticeable during `emerge --regen`. |
32 |
|
33 |
-- |
34 |
Arfrever Frehtes Taifersar Arahesis |