Gentoo Archives: gentoo-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] RFC: devqawarn()?
Date: Thu, 01 Sep 2011 17:12:18
Message-Id: 4E5FBCC5.9020605@gentoo.org
In Reply to: Re: [gentoo-dev] RFC: devqawarn()? by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 On 09/01/2011 09:19 AM, Michał Górny wrote:
5 > On Thu, 01 Sep 2011 08:25:14 -0700 Zac Medico <zmedico@g.o>
6 > wrote:
7 >
8 >> On 09/01/2011 04:02 AM, Petteri Räty wrote:
9 >>> Have Portage defaults so that users only see if them if they
10 >>> read the merge logs and then developer profiles can set the
11 >>> settings to log them?
12 >>
13 >> As far as I know, this is already the case. The current default
14 >> set by portage in /usr/share/portage/config/make.globals is
15 >> PORTAGE_ELOG_CLASSES="log warn error", and in the developer
16 >> profile gentoo-x86/profiles/targets/developer/make.defaults we
17 >> have PORTAGE_ELOG_CLASSES="${PORTAGE_ELOG_CLASSES} qa".
18 >
19 > How about adjusting the eutils.eclass fallback to do so?
20 >
21 > Patch attached.
22 >
23 > Index: eutils.eclass
24 > ===================================================================
25 >
26 >
27 RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
28 > retrieving revision 1.362 diff -u -B -d -u -p -r1.362
29 > eutils.eclass --- eutils.eclass 9 Aug 2011 00:43:48 -0000 1.362 +++
30 > eutils.eclass 1 Sep 2011 16:16:40 -0000 @@ -70,7 +70,9 @@ fi #
31 > implementation if available. if ! declare -F eqawarn >/dev/null ;
32 > then eqawarn() { - einfo "$@" + if has qa
33 > ${PORTAGE_ELOG_CLASSES}; then + ewarn "$@" + fi } fi
34
35 Looks good to me.
36 - --
37 Thanks,
38 Zac
39 -----BEGIN PGP SIGNATURE-----
40 Version: GnuPG v2.0.17 (GNU/Linux)
41 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
42
43 iEYEARECAAYFAk5fvMQACgkQ/ejvha5XGaMyQwCgqS63azOhQF/pWBNq1kN4vNr0
44 nMQAnRdnwUG8GFaSv9o5RawemeaXFWqb
45 =AL1B
46 -----END PGP SIGNATURE-----