Gentoo Archives: gentoo-dev

From: Jonathan Callen <abcd@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: xfconf.eclass
Date: Mon, 26 Jul 2010 19:50:21
Message-Id: 4C4DE6E3.1090401@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: xfconf.eclass by Samuli Suominen
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 07/26/2010 03:03 PM, Samuli Suominen wrote:
5 > On 07/26/2010 09:57 PM, Samuli Suominen (ssuominen) wrote:
6 >
7 > Small change to xfconf.eclass, let me know if you see something wrong
8 > with it.
9 >
10 > - None of xfconf.eclass consumers install static archives (.a) because
11 > xfce libs are simply not useful static.
12 > - We don't have any plugins/libraries using libltdl.
13 >
14 > Therefore .la files have been annoying side product.
15 > So at the risk of breaking one or two users due to disappearing
16 > 'libxfce4util.la', this seems to be the cleanest way to be done with it.
17 > The fix is obvious to most: lafilefixer
18 >
19 >> --- xfconf.eclass 13 Jun 2010 16:10:21 -0000 1.16
20 >> +++ xfconf.eclass 26 Jul 2010 18:57:14 -0000 1.17
21 >> @@ -1,6 +1,6 @@
22 >> # Copyright 1999-2009 Gentoo Foundation
23 >> # Distributed under the terms of the GNU General Public License v2
24 >> -# $Header: /var/cvsroot/gentoo-x86/eclass/xfconf.eclass,v 1.16 2010/06/13 16:10:21 ssuominen Exp $
25 >> +# $Header: /var/cvsroot/gentoo-x86/eclass/xfconf.eclass,v 1.17 2010/07/26 18:57:14 ssuominen Exp $
26 >>
27 >> # @ECLASS: xfconf.eclass
28 >> # @MAINTAINER:
29 >> @@ -138,6 +138,9 @@
30 >> if [[ -n ${DOCS} ]]; then
31 >> dodoc ${DOCS} || die "dodoc failed"
32 >> fi
33 >> +
34 >> + has "${EAPI:-0}" 0 1 2 && ! use prefix && ED="${D}"
35 >> + find "${ED}" -name '*.la' -exec rm -f {} +
36 >> }
37 >>
38 >> # @FUNCTION: xfconf_pkg_preinst
39
40 Personally, I would have just done `find "${D}" -name '*.la' -exec rm -f
41 {} +`, because there are no files in $D that are not in $ED (if there
42 are, portage will refuse to merge the package on Prefix).
43 -----BEGIN PGP SIGNATURE-----
44 Version: GnuPG v2.0.16 (GNU/Linux)
45 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
46
47 iQIcBAEBCAAGBQJMTebjAAoJELHSF2kinlg4/3YQAILmGYFlLkzVnMdD4mUGifLx
48 kZjMs3klDcWguQXJmA2sYRSSZtV/g5Men5/yfvjOIGGtiW0LUBuJl7BawCnhiddp
49 uXjtlbVUGSOmQjWp/xy4gDyv21DYd/H/kcLmDcfjgfIObxyXC0X9q1VLG44ggGkj
50 M5PML/2me17ArOy3hXbj/T/HtpTI1cp+EOw+Kp7XLhLrnztgocAh2taNcpnHQM1a
51 rws+GEXbUkLguGQek+rcw9xhzVMhe/11ZdZWvsudNqwFsTZ2cOcSH4UxxxvbbFnb
52 b8Qujh7Wqfz3sWEoaSGaoLPVGwgxy35SIsdBRdvvvFjLFc2Vuga9iAW4adgV1IyM
53 oTXntGgKhzaRnJe+oousQioURqzYUA2eaq5rb67hyxGIUd2UwRR9nK86hSfgC5XT
54 z2Y6TC8CmrPQD+6jptvdrnCFaGn7Cz8glM99x4qOnkvr35k9hUHZpu3U4Ca3s7V7
55 xu6qA6U/pbXglHGHc4ug3YUqDZFx/yMROI9YL+Mf2Ogt/EnC/oORL1g1VteRWlUO
56 frvd1K1F2JqAq2SS1o15U7kQ9vapSU2sCBsbAtg6CfmEGMACngIug86jQlJKtJ7f
57 B0+2O/dImIhvpH0E9BkHB6zcCa4tRwur5KO8i+U/sMmo2ZBSOx/VcysUGkW9b0J/
58 eNusNJ6xg+eDP1uITD26
59 =fTXV
60 -----END PGP SIGNATURE-----