1 |
>>>>> On Tue, 30 Aug 2011, TomᨠChvátal wrote: |
2 |
|
3 |
> See the attachment for the latest version :) |
4 |
|
5 |
> # @FUNCTION: office-ext_get_implementation |
6 |
> [...] |
7 |
> for i in "${implementations[$@]}"; do |
8 |
|
9 |
I think this should read "${implementations[@]}" instead, if the |
10 |
intention is to loop over all array elements. |
11 |
|
12 |
> # @FUNCTION: office-ext_remove_extension |
13 |
> [...] |
14 |
> ${UNOPKG_BINARY} remove --shared "${ext}" \ |
15 |
|
16 |
Not sure what unopkg accepts, but I guess you want to pass several |
17 |
arguments here. So ${ext} shouldn't be quoted. |
18 |
|
19 |
And why is the intermediate variable ext needed here, in the first |
20 |
place? You could use "$@" directly (this time, with the quotes). |
21 |
|
22 |
> # @FUNCTION: office-ext_src_install |
23 |
> [...] |
24 |
> # subshell to not polute rest of the env with the insinto redefinition |
25 |
|
26 |
s/polute/pollute/ |
27 |
|
28 |
> for i in "${OO_EXTENSIONS[$@]}"; do |
29 |
|
30 |
See above about $@. |
31 |
|
32 |
> # @FUNCTION: office-ext_pkg_postinst |
33 |
> [...] |
34 |
> for i in "${OO_EXTENSIONS[$@]}"; do |
35 |
|
36 |
Ditto. |
37 |
|
38 |
> # @FUNCTION: office-ext_pkg_prerm |
39 |
> [...] |
40 |
> for i in "${OO_EXTENSIONS[$@]}"; do |
41 |
|
42 |
Ditto. |
43 |
|
44 |
Ulrich |