Gentoo Archives: gentoo-dev

From: James Cloos <cloos@×××××××.com>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: git-2.eclass final review
Date: Sun, 17 Apr 2011 18:33:01
Message-Id: m3r590bug6.fsf@jhcloos.com
In Reply to: [gentoo-dev] Re: git-2.eclass final review by "Tomá? Chvátal"
1 That looks good (by inspection).
2
3 My only concern is the branch deletion in the non-bare update.
4
5 First of all, * should be escaped. It seems to work OK with gnu grep,
6 but it would be better to be explicit. (grep(1) says that only ?+{|()
7 loose their meta-meaning in basic regexps.)
8
9 Second, why delete the other branches at all? I'd rather have a
10 complete clone. Just the checkout ought to be enough.
11
12 Otherwise, cool.
13
14 -JimC
15 --
16 James Cloos <cloos@×××××××.com> OpenPGP: 1024D/ED7DAEA6

Replies

Subject Author
Re: [gentoo-dev] Re: git-2.eclass final review "Tomáš Chvátal" <scarabeus@g.o>