1 |
2010-07-05 18:26:40 Samuli Suominen napisał(a): |
2 |
> On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote: |
3 |
> > 2010-07-05 18:13:26 Samuli Suominen napisał(a): |
4 |
> >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: |
5 |
> >>> These minor changes in python.eclass and distutils.eclass have been already |
6 |
> >>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar |
7 |
> >>> with internals of current code before trying to understand these minor changes. |
8 |
> >>> Suggestions about indentation and quoting will be rejected. |
9 |
> >>> |
10 |
> >> |
11 |
> >> You have been already told to get rid of all the color customizations in |
12 |
> >> the python eclasses here: |
13 |
> >> |
14 |
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2 |
15 |
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3 |
16 |
> >> |
17 |
> >> [ .. ] |
18 |
> >> |
19 |
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 |
20 |
> >> |
21 |
> >> The bug was wrongly closed as fixed, as it's not really fixed before |
22 |
> >> it's all punted |
23 |
> > |
24 |
> > Colors can be used with echo. |
25 |
> > |
26 |
> |
27 |
> Stop using echo for output and switch to standard output functions, like |
28 |
> einfo/eerror/elog/... like told in |
29 |
> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 |
30 |
|
31 |
You should read relevant part of comment #7: |
32 |
"The colors can of course be continued to be used in outputs that are purely build |
33 |
time outputting and not for communicating things for users like what cmake builds do." |
34 |
|
35 |
python.eclass uses colors for build time outputting, which doesn't communicate anything for users. |
36 |
|
37 |
-- |
38 |
Arfrever Frehtes Taifersar Arahesis |