1 |
Calling "use" in global scope isn't allowed so what are you suggesting |
2 |
they do instead? |
3 |
|
4 |
On Tue, Jun 12, 2012 at 11:02 PM, Mike Frysinger <vapier@g.o> wrote: |
5 |
> i've noticed a growing trend where people put setup of variables into |
6 |
> pkg_setup that only matter to src_* funcs presumably so they don't have to |
7 |
> call the respective src_* func from an inherited eclass. unfortunately this |
8 |
> adds pointless overhead to binpkgs. can we please move away from this |
9 |
> practice ? |
10 |
> |
11 |
> i've seen this with a good number of the GNOME packages like: |
12 |
> pkg_setup() { |
13 |
> G2CONF="${G2CONF} |
14 |
> --disable-bash-completion |
15 |
> --disable-hal |
16 |
> --disable-schemas-compile |
17 |
> --with-dbus-service-dir=/usr/share/dbus-1/services |
18 |
> $(use_enable afp) |
19 |
> $(use_enable archive) |
20 |
> $(use_enable avahi) |
21 |
> $(use_enable bluetooth obexftp) |
22 |
> $(use_enable bluray) |
23 |
> $(use_enable cdda) |
24 |
> $(use_enable fuse) |
25 |
> $(use_enable gdu) |
26 |
> $(use_enable gphoto2) |
27 |
> $(use_enable ios afc) |
28 |
> $(use_enable udev) |
29 |
> $(use_enable udev gudev) |
30 |
> $(use_enable http) |
31 |
> $(use_enable gnome-keyring keyring) |
32 |
> $(use_enable samba)" |
33 |
> } |
34 |
> |
35 |
> ugh |
36 |
> -mike |