Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: pva@g.o
Subject: Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)
Date: Tue, 28 Jun 2011 06:54:05
Message-Id: 20110628085403.5cc5b535@pomiocik.lan
In Reply to: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS) by Peter Volkov
1 On Tue, 28 Jun 2011 10:16:06 +0400
2 Peter Volkov <pva@g.o> wrote:
3
4 > But still our documentation explicitly suggests ':' for CFLAGS cases
5 > and example allows bash substitution.
6 >
7 > http://devmanual.gentoo.org/ebuild-writing/functions/src_compile/building/index.html
8 > see example in "Fixing Compiler Usage" section and text below:
9 > sed -i -e "s:cc -O2:$(tc-getCC) ${CFLAGS} ${LDFLAGS}:" build.sh
10 >
11 > Are there any objections to suggest '|' for CFLAGS, LDFLAGS (see
12 > attachment)?
13
14 I think that also a good idea may be to provide an Makefile example,
15 showing that often sed is unnecessary, and it's enough to do things
16 like:
17
18 emake CC="$(tc-getCC)" CFLAGS="${CFLAGS}"...
19
20 --
21 Best regards,
22 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies