| 1 |
On Wed, Feb 22, 2012 at 12:33 PM, Matthew Summers |
| 2 |
<quantumsummers@g.o> wrote: |
| 3 |
> On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue <eva@g.o> wrote: |
| 4 |
>> Le dimanche 19 février 2012 à 12:06 +0100, Justin a écrit : |
| 5 |
>>> Hi, |
| 6 |
>>> |
| 7 |
>>> any objections against following patch for subversion.eclass? |
| 8 |
>>> Fixes bug 401737. Basically respects ESVN_{USER,PASSWORD} during |
| 9 |
>>> reemerge of a package. |
| 10 |
>>> |
| 11 |
>>> |
| 12 |
>>> --- subversion.eclass 2012-02-07 11:56:27.000000000 +0200 |
| 13 |
>>> +++ subversion.eclass 2012-02-07 11:59:38.000000000 +0200 |
| 14 |
>>> @@ -469,7 +469,9 @@ |
| 15 |
>>> local target="${1}" |
| 16 |
>>> local key="${2}" |
| 17 |
>>> |
| 18 |
>>> - env LC_ALL=C svn info "${target}" | grep -i "^${key}" | cut -d" " -f2- |
| 19 |
>>> + env LC_ALL=C svn info \ |
| 20 |
>>> + ${options} --username "${ESVN_USER}" --password "${ESVN_PASSWORD}" \ |
| 21 |
>>> + "${target}" | grep -i "^${key}" | cut -d" " -f2- |
| 22 |
>>> } |
| 23 |
>>> |
| 24 |
>>> ## -- subversion__get_repository_uri() |
| 25 |
>>> --------------------------------------- # |
| 26 |
>> |
| 27 |
>> I'm not an expert of the subversion eclass, but the diff looks good. |
| 28 |
>> |
| 29 |
>> -- |
| 30 |
>> Gilles Dartiguelongue <eva@g.o> |
| 31 |
>> Gentoo |
| 32 |
> |
| 33 |
> Why would you want a password in an ebuild? The var ESVN_PASSWORD |
| 34 |
> seems like trouble to me. |
| 35 |
|
| 36 |
I think the intended usage is by the user on the command line, or in a |
| 37 |
package.env file. |
Archives