Gentoo Logo
Gentoo Spaceship

Installation:
Gentoo Handbook
Installation Docs

Documentation:
Home
Listing
About Gentoo
Philosophy
Social Contract

Resources:
Bug Tracker
Developer List
Discussion Forums
Gentoo BitTorrents
Gentoo Linux Enhancement Proposals
IRC Channels
Mailing Lists
Mirrors
Name and Logo Guidelines
Online Package Database
Security Announcements
Staffing Needs
Supporting Vendors
View our CVS

Graphics:
Logos and themes
Icons
ScreenShots

Miscellaneous Resources:
Gentoo Linux Store
Gentoo-hosted projects
IBM dW/Intel article archive




List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Ali Polatel <hawking@g.o>
Subject: Re: gentoo-x86 commit in eclass: distutils.eclass
Date: Thu, 31 Jan 2008 16:51:58 +0200

 1.1

Donnie Berkholz yazmış:
> On 22:19 Wed 23 Jan     , Ali Polatel (hawking) wrote:
> > hawking     08/01/23 22:19:05
> > 
> >   Modified:             distutils.eclass
> >   Log:
> >   Fixed ROOT usage for distutils_pkg_postinst failing when ROOT ends with slash
> 
> > @@ -99,11 +99,14 @@
> >  distutils_pkg_postinst() {
> >  	PYTHON_MODNAME=${PYTHON_MODNAME:-${PN}}
> >  
> > +	# strip trailing slash
> > +	myroot="${ROOT%/}"
> > +
> >  	if has_version ">=dev-lang/python-2.3"; then
> >  		python_version
> >  		for pymod in ${PYTHON_MODNAME}; do
> > -			if [ -d "${ROOT}usr/$(get_libdir)/python${PYVER}/site-packages/${pymod}" ]; then
> > -				python_mod_optimize ${ROOT}usr/$(get_libdir)/python${PYVER}/site-packages/${pymod}
> > +			if [ -d "${myroot}/usr/$(get_libdir)/python${PYVER}/site-packages/${pymod}" ]; then
> > +				python_mod_optimize ${myroot}/usr/$(get_libdir)/python${PYVER}/site-packages/${pymod}
> >  			fi
> >  		done
> >  	fi
> 
> Seems like this might be better fixed by properly handling ROOT in 
> python.eclass instead of hacking around it.
> 

You're right. dev-zero has made some changes to these eclasses in python
overlay[1] which I'll merge to the tree after some more testing.

[1]: http://overlays.gentoo.org/proj/python/browser/overlays/testing/eclass

-ali
Attachment:
pgpPd5wNp6zC6.pgp (PGP signature)
References:
Re: [gentoo-commits] gentoo-x86 commit in eclass: distutils.eclass
-- Donnie Berkholz
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: [gentoo-commits] gentoo-x86 commit in eclass: distutils.eclass
Next by thread:
detecting if a file is used or not
Previous by date:
Re: Redux: removal of digest files from the tree
Next by date:
Re: debianutils: system worthy ?


May 29, 2008

Donate to support our development efforts.

Gentoo Centric Hosting: vr.org

VR Hosted

Tek Alchemy

Tek Alchemy

SevenL.net

SevenL.net

php|architect

php|architect

Copyright 2001-2007 Gentoo Foundation, Inc. Questions, Comments? Email www@gentoo.org.