1 |
i've noticed a growing trend where people put setup of variables into |
2 |
pkg_setup that only matter to src_* funcs presumably so they don't have to |
3 |
call the respective src_* func from an inherited eclass. unfortunately this |
4 |
adds pointless overhead to binpkgs. can we please move away from this |
5 |
practice ? |
6 |
|
7 |
i've seen this with a good number of the GNOME packages like: |
8 |
pkg_setup() { |
9 |
G2CONF="${G2CONF} |
10 |
--disable-bash-completion |
11 |
--disable-hal |
12 |
--disable-schemas-compile |
13 |
--with-dbus-service-dir=/usr/share/dbus-1/services |
14 |
$(use_enable afp) |
15 |
$(use_enable archive) |
16 |
$(use_enable avahi) |
17 |
$(use_enable bluetooth obexftp) |
18 |
$(use_enable bluray) |
19 |
$(use_enable cdda) |
20 |
$(use_enable fuse) |
21 |
$(use_enable gdu) |
22 |
$(use_enable gphoto2) |
23 |
$(use_enable ios afc) |
24 |
$(use_enable udev) |
25 |
$(use_enable udev gudev) |
26 |
$(use_enable http) |
27 |
$(use_enable gnome-keyring keyring) |
28 |
$(use_enable samba)" |
29 |
} |
30 |
|
31 |
ugh |
32 |
-mike |