1 |
On 02/03/2012 15:22, Bertrand Jacquin wrote: |
2 |
> On 02.03.2012 15:35, Peter Stuge wrote: |
3 |
>> Mike Frysinger wrote: |
4 |
>>> if you capture all of the $PORTDIR/$CATEGORY/$PN/ and $A, then |
5 |
>>> there should be no need to manually hook into epatch |
6 |
>> |
7 |
>> The point of hooking into epatch would be to only have exactly those |
8 |
>> patches which get applied. Some ebuilds come with a huge set of |
9 |
>> patches, but only few may be applied depending on USE and version. |
10 |
>> It's nice to have just the right ones. |
11 |
> |
12 |
> epatch is not the only necessary thing, some ebuilds do 'sed -i' on |
13 |
> files. I don't really know for autotools files. |
14 |
|
15 |
Hmm, this is an interesting thought. |
16 |
|
17 |
My instinct would be to consider this under the heading of "build |
18 |
recipe" since it's arguably similar to what the makefile and other |
19 |
pre-processors are doing. I don't disagree that someone could argue |
20 |
this all kinds of ways, but I think you would have to be fairly bloody |
21 |
minded to try for an infringement claim if the ebuild were provided |
22 |
(since arguably the patch is there)? |
23 |
|
24 |
It also occurs to me that it's safer to include all of $ FILESDIR, or at |
25 |
least everything without a .patch extension, since there is also "cp |
26 |
$FILESDIR/somefile $S" to watch for? |
27 |
|
28 |
> An extension about Mike mind can be an automagic diff between all |
29 |
> SRC_URI freshly src_unpack(ed) and after install+distclean or after |
30 |
> src_prepare. Assuming that not any other code is modified during |
31 |
> src_(compile|install). |
32 |
|
33 |
A very simple solution is to diff the code - however, I claim this is |
34 |
*incredibly* unhelpful to the whole notion of open source. If I were |
35 |
the copyright holder then I would far rather have a cooperative, but |
36 |
accidentally non compliant distributor who has genuinely made an effort, |
37 |
than someone who just provides a massive code diff... (Yeah, probably |
38 |
some corner case in that argument, but the point is that patches like |
39 |
"fix segfault on touching some file" are infinitely more useful than a |
40 |
massive diff...) |
41 |
|
42 |
|
43 |
Thanks for the feedback |
44 |
|
45 |
Ed W |