Gentoo Archives: gentoo-genkernel

From: "Rick \\\"Zero_Chaos\\\" Farina" <zerochaos@g.o>
To: gentoo-genkernel@l.g.o
Subject: [gentoo-genkernel] [PATCH] e2fsprogs
Date: Fri, 24 Aug 2012 20:35:54
Message-Id: 5037E62D.1000305@gentoo.org
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 I have chosen (under duress) to break up my patch to make it a bit more
5 manageable. When this is all done I'm certain this will make the
6 outcome far better for everyone.
7
8 To that end, here is the first part for review (not acceptance) which is
9 likely horribly whitespace damaged since I'm just going to copy and
10 paste it.
11
12 I can't figure out to prevent line wrap so, sorry about that.
13
14 This is as close as I can get to mimicking blkid style inclusion of the
15 e2fs progs that I need. I see two potential issues.
16 1.) This isn't really conditional in any way afaict
17 2.) I *need* the e2fs progs for other parts of my patchset but if
18 e2fsprogs are not installed on the system won't this fail horribly? Do
19 we add e2fsprogs to the rdep of the ebuild or what?
20
21 thanks,
22 Zero
23
24 diff --git a/gen_initramfs.sh b/gen_initramfs.sh
25 index ac90830..75bb47f 100755
26 - --- a/gen_initramfs.sh
27 +++ b/gen_initramfs.sh
28 @@ -127,6 +127,26 @@ append_busybox() {
29 rm -rf "${TEMP}/initramfs-busybox-temp" > /dev/null
30 }
31
32 +# Used to add e2fs file making inside initramfs for aufs changes saving
33 +append_e2fstools(){
34 + if [ -d "${TEMP}/initramfs-e2fsprogs-temp" ]
35 + then
36 + rm -r "${TEMP}/initramfs-e2fsprogs-temp/"
37 + fi
38 + #print_info 1 'E2FSTOOLS: Adding support (compiling binaries)...'
39 + # Using different name for blkid compatibility
40 + #compile_e2fstools
41 + cd ${TEMP}
42 + mkdir -p "${TEMP}/initramfs-e2fsprogs-temp/"
43 + #XXX: do we want to add an if statement here or just include it? I say
44 include it...
45 + copy_binaries "${TEMP}"/initramfs-e2fsprogs-temp/ /sbin/{e2fsck,mke2fs}
46 + #/bin/tar -jxpf "${E2FSPROGS_BINCACHE}" -C
47 "${TEMP}/initramfs-e2fsprogs-temp/" ||
48 + # gen_die "Could not extract e2fsprogs binary cache!"
49 + cd "${TEMP}/initramfs-e2fsprogs-temp/"
50 + find . -print | cpio ${CPIO_ARGS} --append -F "${CPIO}"
51 + rm -rf "${TEMP}/initramfs-e2fsprogs-temp" > /dev/null
52 +}
53 +
54 append_blkid(){
55 if [ -d "${TEMP}/initramfs-blkid-temp" ]
56 then
57 @@ -624,6 +644,7 @@ append_auxilary() {
58 rm -r "${TEMP}/initramfs-aux-temp/"
59 fi
60 mkdir -p "${TEMP}/initramfs-aux-temp/etc"
61 + mkdir -p "${TEMP}/initramfs-aux-temp/bin"
62 mkdir -p "${TEMP}/initramfs-aux-temp/sbin"
63 if [ -f "${CMD_LINUXRC}" ]
64 then
65 @@ -741,6 +762,7 @@ create_initramfs() {
66 append_data 'base_layout'
67 append_data 'auxilary' "${BUSYBOX}"
68 append_data 'busybox' "${BUSYBOX}"
69 + append_data 'e2fstools'
70 append_data 'lvm' "${LVM}"
71 append_data 'dmraid' "${DMRAID}"
72 append_data 'iscsi' "${ISCSI}"
73 -----BEGIN PGP SIGNATURE-----
74 Version: GnuPG v2.0.19 (GNU/Linux)
75 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
76
77 iQIcBAEBAgAGBQJQN+YsAAoJEKXdFCfdEflKzYgQALBWW+3mULQJD2/ITFzfDwlv
78 LPztO6X78Ddi1T7oCcwXjxwdAJYUtHqGrR/56Lhgablnl3VFNGJXWEf31M1sjCD3
79 qu1PUMb1cr0x+vz4WnGAg92KEKNLaOiNFFTAIZFNBY3ZzfqYREBC+bgZGNYc8Dnt
80 8q3jiEQRwfb1Mkx7kwoGxoknAu1u4gggDnwOAhglgGnISLvhNgg6g5MCCK/YVf2W
81 6z/ZR90+jVn2JJ7ULwLkgkIR5hAepKZJB44lD/PXReZHDTI9yEHnHksBF9DwRF7x
82 brsDLeNLh38xKv+rr72CTv4RAOyV8us7MJaASqVc6qOLUqXxLgLbx27XOrZKr7cP
83 H+ceApmYd4cP04NzGzGqDEPnXMlE4V+fj0kQDpCmZ8yG9n6ae7zZ5TyYOhmLqpqt
84 +SyLDDA3u5SRR3xo6KHcRBVBXf1nvxZq1RsRhwTE/Nhcg5pWXEJcj2H45HohfwrK
85 BviIDHC60sy0FvRp4ndXVXGBlmCLCekNq5VJXEv2o6HSGbA+hxT2gK/sILym9ym/
86 GZ6MIqzWVJQpEKvipVpJOMFD95o+Q9iNIezL6UwoRM/Tbj4MQE9oa0sww+ikavri
87 NGoIyJZ73+8TkM/lI9Jr29YJ0WvyLvII161TiC59mIxDOEON5/mUptwzDqXKaEjo
88 pqe3lJG7ighBPf0CznFJ
89 =aD5n
90 -----END PGP SIGNATURE-----

Replies

Subject Author
Re: [gentoo-genkernel] [PATCH] e2fsprogs Sebastian Pipping <sping@g.o>