1 |
On Fri, 2008-01-04 at 10:27 -0700, Dmitry S. Makovey wrote: |
2 |
|
3 |
> Just as an update - those pointers were really useful and I was able to |
4 |
> finalize ebuild after all (see http://bugs.gentoo.org/show_bug.cgi?id=106890 |
5 |
> for finalized version). |
6 |
|
7 |
I have some questions; see below ... |
8 |
|
9 |
> However, just to stay on the "purist" side - using "inherit gnustep-2" as |
10 |
> suggested in eclasses pulls in some dependancies that are not really needed |
11 |
> (like gnustep-gui and some other) which is not very gentoo-like. Is there a |
12 |
> plan to produce more modular eclasses to inherit from (I used "inherit |
13 |
> gnustep" and "DEPEND=gnustep-base" initially but comments in gnustep class |
14 |
> suggest that it's deprecated)? |
15 |
|
16 |
You can ask one of the GNUstep developers -- why does the gnustep-2 |
17 |
eclass have a dependency for gnustep-back? Not all GNUstep-based |
18 |
applications are GUI. |
19 |
|
20 |
I have other questions/comments about your ebuild, which will help get |
21 |
it accepted by the Gentoo devs: |
22 |
|
23 |
* KEYWORDS should be ~x86/~amd64 until it has passed the testing phase, |
24 |
not x86/amd64 |
25 |
|
26 |
* Use "cp -pr" instead of piping with tar |
27 |
|
28 |
* Don't hard code the paths for "openapp" and "oolite.app" in your |
29 |
wrapper script. If there is a working GNUstep installation, openapp |
30 |
will be in the PATH, and the app will be found by openapp through |
31 |
GNUstep. |
32 |
|
33 |
* Your DEPEND and RDEPEND are really confusing. Specifically: |
34 |
- Why are the versions for stuff under x86 in RDEPEND, but not in |
35 |
DEPEND? Doesn't amd64 need those minimum versions? |
36 |
- Also, doesn't amd64 need x11 and gnustep-env? |
37 |
|
38 |
Typing this now, it looks like mr_bones already made some comments on |
39 |
bugzilla -- hopefully with that and this you can polish off the ebuild. |
40 |
|
41 |
|
42 |
Best, |
43 |
|
44 |
Sourav |
45 |
|
46 |
-- |
47 |
gentoo-gnustep@g.o mailing list |