DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=B5WWbzl4cOhy51QsFkUuddit7VCRG8YUTsU6grwnsaLYFAuu+OD3ti19TaWhwh9beH
         OwbWAUQlIfK8YrY0tJFoML2ZQKD7lmNXCXC67BvYQHeMfVamLpd8ZM6aoPzHp4NryGz0
         YM21uMk2C3wSzvzoNmcQzFyCRyOgQqnzJNpkw=
MIME-Version: 1.0
In-Reply-To: <4C20DFC0.9000107@gmx.net>
References: <4C20DFC0.9000107@gmx.net>
Date: Wed, 23 Jun 2010 08:30:27 +1000
Message-ID: <AANLkTik7bjJNcCoj5hu8caPSBJke3B9agU8isRZGf7Qf@mail.gmail.com>
Subject: Re: jnr-netdb requires Java 6
From: Wayne Meissner <wmeissner@gmail.com>
To: Martin von Gagern <Martin.vGagern@gmx.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Thanks for pointing both those issues out!

Yup, the line.length check should be checking for line.length <1 (or
<=3D 0).  Will apply those changes and update when I get a chance.

btw, if there's anything else needed to make the gentoo build a bit
easier, let me know.

On 23 June 2010 02:07, Martin von Gagern <Martin.vGagern@gmx.net> wrote:
> Dear Wayne,
>
> the jnr-netdb package you develop currently does require Java 6 because
> in jnr/netdb/NetDBIterator.java you make use of String.isEmpty(). It
> would be fairly easy to change that requirement to Java 5 by using a
> String.length() =3D=3D 0 check instead.
>
> I also noticed that the line in question not only has this compatibility
> problem, but has a bug as well: it contains a check for "line.length <
> 0", with line being an array. The length of an array will never be
> negative, and in case of zero length the check won't prevent subsequent
> access to line[0] in case of a zero-length array, thereby leading to an
> ArrayIndexOutOfBoundsException. Haven't experienced this in real life,
> but you should probably fix the code in any case, and perhaps add a test
> case ensuring proper behaviour.
>
> https://bugs.gentoo.org/show_bug.cgi?id=3D325079#c1 has a patch addressin=
g
> both these issues. I'll attach a copy here.
>
> Greetings,
> =A0Martin von Gagern
>