Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-java
Navigation:
Lists: gentoo-java: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-java@g.o
From: Hanno Meyer-Thurow <h.mth@...>
Subject: Re: RFC: Local Javadoc Linking
Date: Sat, 24 Oct 2009 12:06:29 +0200
On Fri, 23 Oct 2009 11:22:30 -0500
Daniel Solano Gómez <gentoo@...> wrote:

> Hello, all,

Hi there!

> I have come up with an initial implementation for this and would like to
> get some feedback from other people. ...

> 2. Modifications to the java-ant-2.eclass:  I added a new function
> java-ant_link-javadoc() that does the work of looking up local
> documentation and calling the helper script.  I also added a hook to the
> function from java-ant-2_src-configure().  This patch is available at:
> https://bugs.gentoo.org/attachment.cgi?id=3D207945

There are two things in the eclass patch I would fix. ;)
1. I recommend the subshell call '$(...)' instead of the old-style '`...`'.
2. There is an hamcrest comment in java-ant_link-javadoc() ?!

> When java-ant_link-javadoc() is called, it first checks to see if
> java-sdk-docs is installed, and if so gets the path to the API
> documentation.

I would add 'doc? ( dev-java/java-sdk-docs:${whatever build vm is used} )'
to java-pkg-2.eclass. But I guess then many will complain. :D

My two cents. :)


Regards,
Hanno


References:
RFC: Local Javadoc Linking
-- Daniel Solano Gómez
Navigation:
Lists: gentoo-java: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
RFC: Local Javadoc Linking
Next by thread:
Re: RFC: Local Javadoc Linking
Previous by date:
RFC: Local Javadoc Linking
Next by date:
Re: RFC: Local Javadoc Linking


Updated Mar 06, 2012

Summary: Archive of the gentoo-java mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.