1 |
On Fri, 23 Oct 2009 11:22:30 -0500 |
2 |
Daniel Solano Gómez <gentoo@×××××××.com> wrote: |
3 |
|
4 |
> Hello, all, |
5 |
|
6 |
Hi there! |
7 |
|
8 |
> I have come up with an initial implementation for this and would like to |
9 |
> get some feedback from other people. ... |
10 |
|
11 |
> 2. Modifications to the java-ant-2.eclass: I added a new function |
12 |
> java-ant_link-javadoc() that does the work of looking up local |
13 |
> documentation and calling the helper script. I also added a hook to the |
14 |
> function from java-ant-2_src-configure(). This patch is available at: |
15 |
> https://bugs.gentoo.org/attachment.cgi?id=3D207945 |
16 |
|
17 |
There are two things in the eclass patch I would fix. ;) |
18 |
1. I recommend the subshell call '$(...)' instead of the old-style '`...`'. |
19 |
2. There is an hamcrest comment in java-ant_link-javadoc() ?! |
20 |
|
21 |
> When java-ant_link-javadoc() is called, it first checks to see if |
22 |
> java-sdk-docs is installed, and if so gets the path to the API |
23 |
> documentation. |
24 |
|
25 |
I would add 'doc? ( dev-java/java-sdk-docs:${whatever build vm is used} )' |
26 |
to java-pkg-2.eclass. But I guess then many will complain. :D |
27 |
|
28 |
My two cents. :) |
29 |
|
30 |
|
31 |
Regards, |
32 |
Hanno |