| 1 |
Mario Fetka wrote: |
| 2 |
> Hallo Gentoo Java Team, |
| 3 |
> |
| 4 |
> can someone plz review some java related ebuilds[1] |
| 5 |
> |
| 6 |
> dev-java/isrt |
| 7 |
> dev-java/isnativec |
| 8 |
> dev-java/isfreetype |
| 9 |
> dev-java/iscwt |
| 10 |
> dev-java/jPod |
| 11 |
> dev-java/jPodRenderer |
| 12 |
> dev-java/jbig2 |
| 13 |
> app-text/pdfsam |
| 14 |
|
| 15 |
Hi, just a quick... I'll talk about iscwt-5.0.20081218.ebuild but most |
| 16 |
should apply to others too. |
| 17 |
|
| 18 |
depends on swt:3.4 using a slot dep without EAPI=1 (or later) which |
| 19 |
should not even work. In general, use EAPI=2 and specify slot deps for |
| 20 |
everything dev-java except jdk/jre (even explicitly :0 as it eases |
| 21 |
future upgrades). With EAPI=2 you can call 'default' instead of 'unpack |
| 22 |
$A; cd $S;'. The mkdir and cp calls should have appen '|| die' |
| 23 |
|
| 24 |
Move doc from IUSE to JAVA_PKG_IUSE. |
| 25 |
The creation of build.properties is tedious, overriding the classpath |
| 26 |
(see below) should be easier. |
| 27 |
What is the ${antflags} doing in src_compile? Should not be there. Also |
| 28 |
there should be just one eant call and using $(use_doc) as parameter |
| 29 |
will add 'javadoc' based on the flag. |
| 30 |
Also the whole src_compile (and the build.properties stuff) could be |
| 31 |
replaced with this: |
| 32 |
|
| 33 |
JAVA_ANT_REWRITE_CLASSPATH="true" |
| 34 |
EANT_GENTOO_CLASSPATH="isnativec,isrt,jna" |
| 35 |
|
| 36 |
Not tested, so some details might vary. Hope it helps. |
| 37 |
Caster |
| 38 |
|
| 39 |
> before i will put them into bugzilla |
| 40 |
> |
| 41 |
> thx in av |
| 42 |
> Mario |
| 43 |
> |
| 44 |
> [1]http://tinyurl.com/co97l6 |
| 45 |
> http://tinyurl.com/dg3vhv |
| 46 |
> |
| 47 |
> |
Archives