1 |
-----BEGIN PGP SIGNED MESSAGE----- |
2 |
Hash: SHA1 |
3 |
|
4 |
On 23-02-12 18:50, Erik Falor wrote: |
5 |
> On Thu, Feb 23, 2012 at 10:14:07AM +0100, Marijn wrote: |
6 |
>> Hi Erik, |
7 |
>> |
8 |
>> I notice that the SRC_URI contains an explicit version. Ideally |
9 |
>> we shouldn't have to adjust it once 4.7.1 and 4.8.0 come out. |
10 |
>> Would ${PV} not accomplish that? |
11 |
> |
12 |
> ${PV} does accomplish that. Thank you for pointing this out. |
13 |
> |
14 |
>> I also notice that the ebuild still unsets some variables (A |
15 |
>> ARCH). I consider it a bug if this is necessary. Have you checked |
16 |
>> whether it is still necessary? If so what is the state of fixing |
17 |
>> portage so we don't need to do this unsetting? |
18 |
> |
19 |
> Unfortunately, this step is still necessary as those variables are |
20 |
> still in conflict with the Makefiles. |
21 |
> |
22 |
> I was not aware that there had been any discussion by the portage |
23 |
> devs about this issue. The only bug I could find is #127560 - is |
24 |
> that the effort you are talking about? Or are you suggesting that |
25 |
> we file a new bug? |
26 |
|
27 |
I thought there was a specific bug about chicken's use of A and that |
28 |
of portage conflicting, but I can't find it now. The Changelog isn't |
29 |
very helpful either. I did find bug 208535 about a similar problem |
30 |
with O which was resolved by fixing portage. |
31 |
I think a good way to move forward is probably to just open a new bug |
32 |
about this. |
33 |
|
34 |
>> Otherwise looks good. |
35 |
>> |
36 |
>> Marijn |
37 |
> |
38 |
> If you feel good about just the ${PV} fix, I'll check this in to |
39 |
> the overlay tonight. |
40 |
|
41 |
You should feel free to commit stuff even if it is has some issues; |
42 |
that's what we have the overlay for. The main tree is a different |
43 |
story, but for the overlay the bar is intentionally really low. That |
44 |
way people can cooperate and improve on each-other's work easily. |
45 |
|
46 |
Marijn |
47 |
|
48 |
-----BEGIN PGP SIGNATURE----- |
49 |
Version: GnuPG v2.0.18 (GNU/Linux) |
50 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ |
51 |
|
52 |
iEYEARECAAYFAk9HilAACgkQp/VmCx0OL2wzTgCfcUHrsRR+Y4cG324JabQW/mgg |
53 |
qIUAn2+KBVFE2nuUcnwdtAWP7d85ozzd |
54 |
=fhRo |
55 |
-----END PGP SIGNATURE----- |