-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 22-02-12 16:56, Erik Falor wrote:
> On Wed, Feb 22, 2012 at 02:26:18PM +0100, Marijn wrote:
>> Hi Erik,
>> 
>> you seem to have forgotten to actually attach anything.
> 
> _____  _       _     _ |  __ \( )     | |   | | | |  | |/  ___ |
> |__ | | | |  | |  / _ \| '_ \| | | |__| | | (_) | | | |_| |_____/
> \___/|_| |_(_)
> 
> My bad.
> 
>> Anyway, it is fine if you commit stuff directly to the overlay,
>> but it's not a bad idea to also post your patches to the list.
> 
> Let's try this again...

Hi Erik,

I notice that the SRC_URI contains an explicit version. Ideally we
shouldn't have to adjust it once 4.7.1 and 4.8.0 come out. Would ${PV}
not accomplish that?

I also notice that the ebuild still unsets some variables (A ARCH). I
consider it a bug if this is necessary. Have you checked whether it is
still necessary? If so what is the state of fixing portage so we don't
need to do this unsetting?

Otherwise looks good.

Marijn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9GA18ACgkQp/VmCx0OL2wa4gCfQ7QJE95Lc/znjDPrIFhDPorA
g7YAn0FbNBfh8FZY2McNrVr+XXUnnF1c
=yWTa
-----END PGP SIGNATURE-----