| 1 |
On Mon, Oct 31, 2005 at 12:20:48AM -0500, Lina Pezzella wrote: |
| 2 |
> -----BEGIN PGP SIGNED MESSAGE----- |
| 3 |
> Hash: SHA1 |
| 4 |
> |
| 5 |
> Actually, I investigated those additional symbols on my linux box, |
| 6 |
> and it appears that they are undefined over there as well. The only |
| 7 |
> difference is that the linker on my linux box didn't care... The |
| 8 |
> package works perfectly fine with those symbols undefined, and if you |
| 9 |
> read the source, some of them are slated to be removed in future |
| 10 |
> versions anyways... |
| 11 |
|
| 12 |
Ah... bleh... Bad source... |
| 13 |
|
| 14 |
> As for environ, it seems that is also entirely unnecessary for |
| 15 |
> graphviz Darwin. If you look at the Darwinports patch for |
| 16 |
> graphviz-2.6, they've simply removed the functionality to error on |
| 17 |
> that symbol being undefined. If you have a solution for this on a |
| 18 |
> large-scale, that'd be great, as I agree with you that it would be |
| 19 |
> more correct, and perhaps could solve other issues. For graphviz |
| 20 |
> though, it seems not to matter. |
| 21 |
|
| 22 |
This is what happens on Linux too in the end, if I get your message |
| 23 |
correctly. So it's fine with me. |
| 24 |
|
| 25 |
> In any case, I modified the Darwinports patch to be dependent on |
| 26 |
> host_os, so that we can patch the source unconditionally in the |
| 27 |
> ebuild. If you want to go the route of fixing the undefined symbol |
| 28 |
> for environ, please don't hesitate to change my patch. Let me know |
| 29 |
> what you decide so that I can contact upstream about the problem. |
| 30 |
|
| 31 |
Personally, I feel the patch is correct for us, but incorrect for |
| 32 |
submission to upstream. We simply ignore a problem with the patch, |
| 33 |
which seems to be ok, but we don't fix a problem. Upstream should fix |
| 34 |
the undefined symbols basically. |
| 35 |
|
| 36 |
So, I would not even think of submitting upstream, earlier tell them |
| 37 |
there are undefined symbols and that they should fix it :p. The |
| 38 |
solution for now is ok, and I trust you that it works. So thanks for |
| 39 |
your research on this thing. I guess we've learnt something again. (At |
| 40 |
least I did...). |
| 41 |
|
| 42 |
Would you please tell on the graphviz bug we (you) fixed it, if you |
| 43 |
haven't already? Of course ignore this if the latter is true. |
| 44 |
|
| 45 |
Thanks again. |
| 46 |
|
| 47 |
-- |
| 48 |
Fabian Groffen |
| 49 |
Gentoo for Mac OS X Project -- Interim Lead |
| 50 |
-- |
| 51 |
gentoo-osx@g.o mailing list |
Archives