Gentoo Archives: gentoo-perl

From: Torsten Veller <ml-en@××××××.net>
To: gentoo-dev@l.g.o
Cc: gentoo-perl@l.g.o
Subject: [gentoo-perl] Re: perl-module.eclass -- review - 2
Date: Sat, 28 Feb 2009 11:33:53
Message-Id: 20090228113953.TAb8d40.tv@veller.net
In Reply to: [gentoo-perl] perl-module.eclass -- review by Torsten Veller
* Torsten Veller <ml-en@××××××.net>:
> Please review the attached perl-module.eclass. > Patch linked below.
Thanks Bo Ørsted Andresen for feedback
> Changes > ~~~~~~~
- use emake - more quoting - call perlinfo only once As I've not seen any ebuild doing the replacement in line 156, I've added a temporary ewarn. If you hits you, tell me.
> git://github.com/tove/perl-eclass.git > http://people.gentoo.org/tove/files/perl-module.eclass.diff

Attachments

File name MIME type
perl-module.eclass text/plain