Gentoo Archives: gentoo-perl

From: antoine.raillon@××××××.net
To: gentoo-perl@l.g.o
Subject: [gentoo-perl] r28 - in trunk: bin extra-docs
Date: Sun, 15 May 2005 12:29:51
Message-Id: 20050515122915.81EAD8280F2@gredin.dragou.net
1 Author: mcummings
2 Date: 2005-05-15 14:29:15 +0200 (Sun, 15 May 2005)
3 New Revision: 28
4
5 Modified:
6 trunk/bin/g-cpan.pl
7 trunk/extra-docs/Changes
8 Log:
9 small cleaning
10
11 Modified: trunk/bin/g-cpan.pl
12 ===================================================================
13 --- trunk/bin/g-cpan.pl 2005-05-15 11:56:29 UTC (rev 27)
14 +++ trunk/bin/g-cpan.pl 2005-05-15 12:29:15 UTC (rev 28)
15 @@ -207,9 +207,6 @@
16 if ($list) {
17 printbig "Generating list of modules managed by g-cpan";
18 my @managed = get_gcpans();
19 -# print "@managed \n" for @managed;
20 -# print "List function not implemented yet.\n";
21 -# exit_usage();
22 }
23
24 if ($install) {
25 @@ -307,45 +304,6 @@
26 return @g_list;
27 }
28
29 -sub build_catdep {
30 -# Needed a way to add category to the dependancy instead of hardcoding dev-perl :/
31 -# On the upside, at this point we know the ebuild exists *somewhere* so we just need to locate it
32 - my ($dir) = lc $_[0];
33 - my $found = '';
34 -
35 - # FIXME Sniper
36 - # not nice construct, put grep inside
37 -
38 - # FIXME mcummings
39 - # Still not nice, but here's the deal. The way it was before, when this was being invoked multiple times,
40 - # it was passing through smaller and smaller sets of dirs each pass until it wasn't checking anything
41 - # Broken for some reason - foreach my $sdir (@PORTAGE_DEV_PERL, @OVERLAY_PERLS, @TMP_DEV_PERL_DIRS, $perldev_overlay) {
42 - my @dir_list;
43 - push @dir_list, @PORTAGE_DEV_PERL;
44 - push @dir_list, @OVERLAY_PERLS;
45 - push @dir_list, @TMP_DEV_PERL_DIRS;
46 - push @dir_list, $perldev_overlay;
47 - foreach my $sdir (@dir_list) {
48 - next if not -d $sdir;
49 - # FIXME Sniper
50 - # maybee replace fatal by "warn and next folder" ?
51 - opendir PDIR, $sdir or fatal(ERR_FOLDER_OPEN, $sdir, $!);
52 - while(my $file = readdir PDIR) {
53 - next if $file eq ".";
54 - next if $file eq "..";
55 - if(lc $file eq $dir ) {
56 - $sdir =~ s/.*\///;
57 - $found = "$sdir/$file";
58 - closedir(PDIR);
59 - return($found);
60 - }
61 - }
62 - closedir(PDIR);
63 - }
64 - # TODO Sniper
65 - # if we are here, $found if undef, what to do ?
66 -}
67 -
68 sub portage_dir {
69 my $obj = shift;
70 my $file = $obj->cpan_file;
71 @@ -457,7 +415,6 @@
72
73 # remove trailing .pm to fix emerge breakage.
74 $dir =~ s/.pm$//;
75 - #$dir = build_catdep($dir);
76 $dir = ebuild_exists($dir);
77 print EBUILD "\n\t" unless $first;
78 print EBUILD "$dir";
79
80 Modified: trunk/extra-docs/Changes
81 ===================================================================
82 --- trunk/extra-docs/Changes 2005-05-15 11:56:29 UTC (rev 27)
83 +++ trunk/extra-docs/Changes 2005-05-15 12:29:15 UTC (rev 28)
84 @@ -1,3 +1,7 @@
85 +15/05/2005 - mcummings
86 +
87 +- Removed sub that was no longer being invoked (had cleaned up the code for this last week)
88 +
89 15/05/2005 - cab, second pass !
90
91 - Played with CPAN stuff so that it comes AFTER options parsing (see rev 25 for FIXME)
92
93
94 --
95 gentoo-perl@g.o mailing list