Note: Due to technical difficulties, the Archives are currently not up to date.
GMANE provides an alternative service for most mailing lists. c.f. bug 424647
List Archive: gentoo-perl
sub ebuild_exists {
- my ($dir) = lc $_[0];
+ my ($dir) = $_[0];
# need to try harder here - see &portage_dir comments.
# should return an ebuild name from this, as case matters.
@@ -264,8 +270,9 @@
next if not -d $sdir;
opendir PDIR, $sdir or fatal(ERR_FOLDER_OPEN, $sdir, $!);
while(my $file = readdir PDIR) {
- if(lc $file eq $dir) {
- $found = $dir;
+ if(lc $file eq lc $dir) {
+ my $cat = basename($sdir);
+ $found = "$cat/$file";
I don't understand this modification.
Why lc($dir) for each file in PDIR, best is one and only lc($dir) at the start
of sub for best performances.
If $found must be the original $dir w/o case change, I propose :
sub ebuild_exists {
my ($dir) = @_;
my $lcase_dir = lc $dir;
[...later...]
while(my $file = readdir PDIR) {
if(lc $file eq $lcase_dir) {
$found = $dir;
$cab->todo->add('svn commit notif email script'); # ;-)
David "Sniper" Rigaudiere
GPG KeyID 0xFF1E982D
--
gentoo-perl@g.o mailing list
|
|