Author: mcummings
Date: 2005-05-15 14:29:15 +0200 (Sun, 15 May 2005)
New Revision: 28
Modified:
trunk/bin/g-cpan.pl
trunk/extra-docs/Changes
Log:
small cleaning
Modified: trunk/bin/g-cpan.pl
===================================================================
--- trunk/bin/g-cpan.pl 2005-05-15 11:56:29 UTC (rev 27)
+++ trunk/bin/g-cpan.pl 2005-05-15 12:29:15 UTC (rev 28)
@@ -207,9 +207,6 @@
if ($list) {
printbig "Generating list of modules managed by g-cpan";
my @managed = get_gcpans();
-# print "@managed \n" for @managed;
-# print "List function not implemented yet.\n";
-# exit_usage();
}
if ($install) {
@@ -307,45 +304,6 @@
return @g_list;
}
-sub build_catdep {
-# Needed a way to add category to the dependancy instead of hardcoding dev-perl :/
-# On the upside, at this point we know the ebuild exists *somewhere* so we just need to locate it
- my ($dir) = lc $_[0];
- my $found = '';
-
- # FIXME Sniper
- # not nice construct, put grep inside
-
- # FIXME mcummings
- # Still not nice, but here's the deal. The way it was before, when this was being invoked multiple times,
- # it was passing through smaller and smaller sets of dirs each pass until it wasn't checking anything
- # Broken for some reason - foreach my $sdir (@PORTAGE_DEV_PERL, @OVERLAY_PERLS, @TMP_DEV_PERL_DIRS, $perldev_overlay) {
- my @dir_list;
- push @dir_list, @PORTAGE_DEV_PERL;
- push @dir_list, @OVERLAY_PERLS;
- push @dir_list, @TMP_DEV_PERL_DIRS;
- push @dir_list, $perldev_overlay;
- foreach my $sdir (@dir_list) {
- next if not -d $sdir;
- # FIXME Sniper
- # maybee replace fatal by "warn and next folder" ?
- opendir PDIR, $sdir or fatal(ERR_FOLDER_OPEN, $sdir, $!);
- while(my $file = readdir PDIR) {
- next if $file eq ".";
- next if $file eq "..";
- if(lc $file eq $dir ) {
- $sdir =~ s/.*\///;
- $found = "$sdir/$file";
- closedir(PDIR);
- return($found);
- }
- }
- closedir(PDIR);
- }
- # TODO Sniper
- # if we are here, $found if undef, what to do ?
-}
-
sub portage_dir {
my $obj = shift;
my $file = $obj->cpan_file;
@@ -457,7 +415,6 @@
# remove trailing .pm to fix emerge breakage.
$dir =~ s/.pm$//;
- #$dir = build_catdep($dir);
$dir = ebuild_exists($dir);
print EBUILD "\n\t" unless $first;
print EBUILD "$dir";
Modified: trunk/extra-docs/Changes
===================================================================
--- trunk/extra-docs/Changes 2005-05-15 11:56:29 UTC (rev 27)
+++ trunk/extra-docs/Changes 2005-05-15 12:29:15 UTC (rev 28)
@@ -1,3 +1,7 @@
+15/05/2005 - mcummings
+
+- Removed sub that was no longer being invoked (had cleaned up the code for this last week)
+
15/05/2005 - cab, second pass !
- Played with CPAN stuff so that it comes AFTER options parsing (see rev 25 for FIXME)
--
gentoo-perl@g.o mailing list
|