| 1 |
On Wed, 15 Apr 2009 17:28:01 +0200 |
| 2 |
Christian Faulhammer <fauli@g.o> wrote: |
| 3 |
> > > 0001: Desk reference, updated and all issues you raised handled. |
| 4 |
> > |
| 5 |
> > You're indenting with two spaces rather than four, and don't have |
| 6 |
> > our precious vim modelines. Lack of consistency makes me cry! |
| 7 |
> |
| 8 |
> Then go change the other files, and if Vim is too dumb to recognise a |
| 9 |
> LaTeX file, I can't help it. |
| 10 |
|
| 11 |
The modelines are there for indenting rules. And if everyone used them, |
| 12 |
the other files wouldn't be in the mess they're in. Maybe. |
| 13 |
|
| 14 |
> 0001: Corrected desk reference. |
| 15 |
|
| 16 |
> + the previous EAPI. All label refer to the PMS document itself, |
| 17 |
> + built from the same checkout as this overview. |
| 18 |
|
| 19 |
s/label/labels/, and s/built/which can be built/ |
| 20 |
|
| 21 |
> + \item[IUSE defaults] An USE flag can be marked as mandatory (if |
| 22 |
|
| 23 |
A use flag, not an. |
| 24 |
|
| 25 |
> + function automatically. so small additions you need will not be |
| 26 |
|
| 27 |
That '.' should be a ','. I'd also say "so any small" rather than "so |
| 28 |
small". |
| 29 |
|
| 30 |
> 0002: Tell Emacs to use retarded indenting in all LaTeX files, so the |
| 31 |
> Vim weenies don't whine. |
| 32 |
|
| 33 |
Applied, thanks. |
| 34 |
|
| 35 |
> 0003: Fix intendation to 4 spaces where needed. |
| 36 |
|
| 37 |
Applied, minus the bits from 0001. |
| 38 |
|
| 39 |
> 0004: Comment class file |
| 40 |
|
| 41 |
Some of the lines in this one have trailing whitespace. Git moans about |
| 42 |
this, and it looks horrible. Can you get your editor to show you these |
| 43 |
so they don't slip through? |
| 44 |
|
| 45 |
Fixed up and applied, minus the bits from 0001. |
| 46 |
|
| 47 |
> 0005: Kick out appendix.sty and a little appendix tweak |
| 48 |
|
| 49 |
Applied, thanks. |
| 50 |
|
| 51 |
> 0006: Some minor Makefile tweaking |
| 52 |
|
| 53 |
This one needs 0001, so I've left it for now. |
| 54 |
|
| 55 |
> 0007: Make email addresses clickable |
| 56 |
|
| 57 |
Applied, thanks. |
| 58 |
|
| 59 |
> And for inital review: |
| 60 |
> 0008: Add Gentoo logo to PMS and desk reference. |
| 61 |
|
| 62 |
What's the copyright / licence / author information for the logo? |
| 63 |
|
| 64 |
You need to update .gitignore for the .png. |
| 65 |
|
| 66 |
There's something weird with convert -- if it doesn't support svg, it |
| 67 |
exits successfully anyway. Not sure whether we can do anything about |
| 68 |
that. |
| 69 |
|
| 70 |
Can't get it to build, either: |
| 71 |
|
| 72 |
! LaTeX Error: File `gentoo-logo' not found. |
| 73 |
|
| 74 |
-- |
| 75 |
Ciaran McCreesh |
Archives