Re: [gentoo-pms] [PATCH 05/22] EAPI 6 supports package.* and use.* directories.

[Michał Górny]

On Thu, 5 Nov 2015 18:38:58 +0000
David Leverton <levertond@××××××××××.com> wrote:

> Ulrich Müller wrote:
> > +\featurelabel{profile-file-dirs} For EAPIs listed as supported in table~\ref{tab:profile-file-dirs},
> > +simple line-based files described in the following sections may optionally be directories containing
> > +files of the named type.
>
> 1) Can those directories themselves contain subdirectories (and
> sub-subdirectories, ...), or is it just one level deep?
>
> 2) Is there any restriction on the names of the files (e.g. ignoring
> hidden files, editor backups, etc), or can they be anything?
>
> If I'm reading the current Portage implementation correctly, the answers
> there (without making any claims about what the spec should or shouldn't
> adopt) are:
>
> 1) Yes, there can be multiple levels of subdirectories.
>
> 2) Yes, files and subdirectories beginning with a . or ending with a ~
> are excluded, as are subdirectories named CVS, RCS or SCCS.

I think your understanding of Portage implementation is correct.
However, I don't really think spec should work like this.

1) I'd go for allowing a single recursion level only. If not for
anything specific, just to keep things simple and avoid further
questions like how to handle symlinks and avoid infinite recursion.
This would also be consistent with how 'eapply' is defined.

2) Dotfiles should be implicitly ignored since that's a common *nix
scheme. If not by any specific exclusion rule, just by simple '*' glob
that wouldn't match those files (this is what happens in eapply).

As for various backup files, I wouldn't put them in the spec. They
don't really belong in the committed repository anyway, so they should
be a minor concern for us.

Long story short, I think this should work alike:

  [[ -d ${foo} ]] && handle "${foo}"/*

Therefore implying single level of recursion and skipping dotfiles.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>