1 |
On Sunday 20 September 2009 17:37:59 Ciaran McCreesh wrote: |
2 |
> On Sun, 20 Sep 2009 17:21:24 +0200 |
3 |
> |
4 |
> Patrick Lauer <patrick@g.o> wrote: |
5 |
> > First change: the test phase is only run when enabled. Since PMS |
6 |
> > doesn't document FEATURES yet we can only say "if tests are enabled" |
7 |
> > instead of being more precise. Well, defining FEATURES shouldn't be |
8 |
> > too hard, but that's for another day. |
9 |
> |
10 |
> Please cross-reference that to the part where we explain that src_test |
11 |
> is run at user option. |
12 |
I fail to find such a thing in current PMS. |
13 |
|
14 |
> You might also want to tidy up the language on |
15 |
> that so that the user option part is explained even if kdebuild is |
16 |
> disabled. |
17 |
I suggest we do as you suggested yesterday and remove kdebuild |
18 |
unconditionally. That saves hacking around something that cannot be in the |
19 |
final version anyway. |
20 |
> |
21 |
> > Second change: The phase order for package updates and reinstalls is |
22 |
> > the same. This makes a whole chunk of the listing redundant, so we |
23 |
> > can collapse it. |
24 |
> |
25 |
> Actually, this one's a bit of a mess, thanks to Portage making a |
26 |
> non-EAPI-controlled order change that was supposed to go in in EAPI 2 |
27 |
> but didn't. |
28 |
Yeah, messy thing. But as you are well aware there was no sane way to make |
29 |
that change EAPI-dependant without causing ambiguous situation and much more |
30 |
confusion. |
31 |
|
32 |
> If you're updating it, please do so to accurately reflect |
33 |
> both orders that can be and are used. |
34 |
Any version of portage in use uses the "later" version. Feel free to document |
35 |
historic behaviour if you want, but as PMS hasn't documented it before I'd put |
36 |
it in the errata section. |
37 |
|
38 |
> > 3 lines added, 21 removed. Isn't decrufting great? |
39 |
> Decrufting is only good if what you're doing really is removing cruft... |
40 |
Well, I've started with the simple things. Once we have the big errors fixed |
41 |
we can move on to the more interesting changes ... |