Re: [gentoo-pms] Re: [PATCH v2] Explain eapply behavior for EAPI 6

[Michał Górny]

Dnia 2015-10-14, o godz. 22:10:38
Ulrich Mueller <ulm@g.o> napisał(a):

> >>>>> On Wed, 14 Oct 2015, Michał Górny wrote:
>
> >> Hm, I previously had "IF the first parameter begins with a hyphen
> >> AND any parameter is equal to --", because the first parameter
> >> certainly cannot be an option argument.
>
> > I know. But does it really make a difference in our case? I wanted
> > to try to make the algorithm a little simpler.
>
> *shrug* Let GNU patch choke on it then.
>
> >> > +\ELSIF{any parameter beginning with a hyphen follows one that does not begin with a hyphen}
> >> > +	\STATE abort the build process with an error
> >>
> >> I suggest "return immediately with an error" here, for consistency
> >> with the wording below.
>
> > Well, I wanted to emphasize difference in error handling. patch
> > failing implies error exit with respect to nonfatal. Usage error is
> > unconditional die.
>
> I see, but then the wording might be more explicit. Maybe instead of
> "If it fails" say "If applying the patches fails" in the description?

Done. Let me resubmit once again.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>