Re: [gentoo-pms] Patches for your reviewing pleasure: Various improvements, including cheat sheet

[Christian Faulhammer]

Hi,

Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>:

> On Wed, 15 Apr 2009 17:28:01 +0200
> Christian Faulhammer <fauli@g.o> wrote:
> > > > 0001: Desk reference, updated and all issues you raised handled.
> > >
> > > You're indenting with two spaces rather than four, and don't have
> > > our precious vim modelines. Lack of consistency makes me cry!
> >
> >  Then go change the other files, and if Vim is too dumb to
> > recognise a LaTeX file, I can't help it.
>
> The modelines are there for indenting rules. And if everyone used
> them, the other files wouldn't be in the mess they're in. Maybe.

 Emacs has set up indenting rules for LaTeX specifically, which is two
spaces in all cases.  And as far as I can see, vim needs the modeline
for character set recognition and mode setting, while Emacs has some
automagic which only makes setting the master file necessary...but
enough from that.  We are both biased.

 You haven't pushed the changes to github.

> > And for inital review:
> > 0008: Add Gentoo logo to PMS and desk reference.
>
> What's the copyright / licence / author information for the logo?

 Gentoo Foundation holds the copyright and we can talk to the trustees
about it.  In the end, PMS is a Gentoo project.

> There's something weird with convert -- if it doesn't support svg, it
> exits successfully anyway. Not sure whether we can do anything about
> that.

 Problem of the user...so a check for USE=svg on imagemagick is then
needed in the ebuild for app-doc/pms. :) 

> Can't get it to build, either:
>
>     ! LaTeX Error: File `gentoo-logo' not found.

 Because you haven't applied some of the patches.

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://gentoo.faulhammer.org/>