Gentoo Archives: gentoo-pms

From: Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>
To: gentoo-pms@l.g.o
Subject: Re: [gentoo-pms] apply_user_patches (was: EAPI 5 development branch)
Date: Mon, 07 May 2012 13:01:13
Message-Id: 20120507135807.6dbc9816@googlemail.com
In Reply to: [gentoo-pms] apply_user_patches (was: EAPI 5 development branch) by Ulrich Mueller
On Mon, 7 May 2012 02:12:14 +0200
Ulrich Mueller <ulm@g.o> wrote:
> | Furthermore, for these EAPIs, if the function is overridden, it > | shall be a fatal error if the apply_user_patches command has not > | been called at least once by the end of the phase. > > Wouldn't it make more sense to call apply_user_patches implicitly at > the end of the phase, if it hasn't been called before? > > Otherwise, a call to that function would have to be added to every > ebuild that defines src_prepare.
That was the point. The discussion on gentoo-dev suggested that "at the end" is often the wrong place to put it, due to eautoreconf etc. We need people to be explicit about where it goes. -- Ciaran McCreesh

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies