1 |
>>>>> On Thu, 16 Mar 2017, Michał Górny wrote: |
2 |
|
3 |
> On czw, 2017-03-16 at 21:58 +0100, Ulrich Mueller wrote: |
4 |
>> I wonder if the "Consistent?" column should be changed to "Yes", |
5 |
>> too? Ebuilds rely on the FILESDIR variable having the same value |
6 |
>> in the src_* phases as it had in global scope. Same for DISTDIR. |
7 |
|
8 |
> Speaking implementation-wise, yes, FILESDIR is now guaranteed to be |
9 |
> consistent. However, FWICS Portage changes DISTDIR between original |
10 |
> path and shadow path. |
11 |
|
12 |
Following discussion in #gentoo-pms, I think we should leave the |
13 |
"Consistent" column alone. Things will still work if these variables |
14 |
(e.g. DISTDIR) point to the real dir in global scope but to a shadow |
15 |
dir in src_* phases. |
16 |
|
17 |
So IMO the original patch is just fine. |
18 |
|
19 |
Ulrich |