| 1 |
On Wednesday 18 February 2009 16:53:43 Christian Faulhammer wrote: |
| 2 |
> Hi, |
| 3 |
> |
| 4 |
> another round for my patch burst. Comment, apply or die. |
| 5 |
|
| 6 |
You might want to read up on "git commit --amend" and "git |
| 7 |
rebase --interactive" ;-) |
| 8 |
|
| 9 |
> punt table default-function-table, as the contents corresponds with |
| 10 |
> default-phase-function-table |
| 11 |
> Patches 08 and 21 |
| 12 |
|
| 13 |
These are technically separate concepts - there could conceivable be an EAPI |
| 14 |
that has default_ functions but not default itself. On the other hand, it's |
| 15 |
not really a big deal, and easy to reverse this change if necessary (probably |
| 16 |
quite unlikely anyway). |
| 17 |
|
| 18 |
> Generate date on titlepage from last commit |
| 19 |
> Patch 11 |
| 20 |
|
| 21 |
This fails if it's not built from a git working tree, as happens with |
| 22 |
git.eclass and pms-99999999.ebuild, and also any snapshot that anyone may or |
| 23 |
may not want to distribute in future. |
| 24 |
|
| 25 |
Everything else seems OK to me. |
Archives