[gentoo-pms] Re: [PATCH] WORKDIR has same scope as FILESDIR and DISTDIR.

[Ulrich Müller]

As pointed out by mgorny [1], S really has the same scope as WORKDIR.
Updated patch below.

[1] https://bugs.gentoo.org/613110


From 46266df1bb3f6a1183a82e19740865fee877be76 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@g.o>
Date: Sat, 18 Mar 2017 15:18:25 +0100
Subject: [PATCH v2] WORKDIR and S have the same scope as FILESDIR and DISTDIR.

Both WORKDIR and S are defined in global scope, but ebuilds must not
access the actual directories. So the FILESDIR footnote applies to
them, too. Rearrange the table accordingly.

Also small change of wording ("in which" -> "where") to prevent an
awkward page break.
---
 ebuild-env-vars.tex | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/ebuild-env-vars.tex b/ebuild-env-vars.tex
index 262bcf9..6b6e1c9 100644
--- a/ebuild-env-vars.tex
+++ b/ebuild-env-vars.tex
@@ -95,6 +95,18 @@ variable.
     Ditto &
     Yes &
     The full path to the directory in which the files in the \t{A} variable are stored. \\
+\t{WORKDIR} &
+    Ditto &
+    Yes &
+    The full path to the ebuild's working directory, where all build data should be contained.%
+    \label{env-var-WORKDIR} \\
+\t{S} &
+    \t{src\_*} &
+    Yes &
+    The full path to the temporary build directory, used by \t{src\_compile}, \t{src\_install} etc.
+    Defaults to \t{\$\{WORKDIR\}/\$\{P\}}. May be modified by ebuilds. If \t{S} is assigned in the
+    global scope of an ebuild, then the restrictions of section~\ref{sec:ebuild-env-state} for
+    global variables apply. \\
 \t{PORTDIR} &
     \t{src\_*} &
     No &
@@ -190,18 +202,6 @@ variable.
     was executed by the package manager. May be unset or any single word that is not any of the
     above when the ebuild is being sourced for other (e.\,g.\ metadata or QA) purposes. Only for
     EAPIs listed in table~\ref{tab:added-env-vars-table} as supporting \t{EBUILD\_PHASE\_FUNC}. \\
-\t{WORKDIR} &
-    \t{src\_*}, global~scope &
-    Yes &
-    The full path to the ebuild's working directory, in which all build data should be
-    contained. \label{env-var-WORKDIR} \\
-\t{S} &
-    \t{src\_*} &
-    Yes &
-    The full path to the temporary build directory, used by \t{src\_compile}, \t{src\_install} etc.
-    Defaults to \t{\$\{WORKDIR\}/\$\{P\}}. May be modified by ebuilds. If \t{S} is assigned in the
-    global scope of an ebuild, then the restrictions of section~\ref{sec:ebuild-env-state} for
-    global variables apply. \\
 \t{KV} &
     All &
     Yes &
-- 
2.12.0