| 1 |
Hi, |
| 2 |
|
| 3 |
David Leverton <levertond@××××××××××.com>: |
| 4 |
|
| 5 |
> On Wednesday 18 February 2009 16:53:43 Christian Faulhammer wrote: |
| 6 |
> > Hi, |
| 7 |
> > |
| 8 |
> > another round for my patch burst. Comment, apply or die. |
| 9 |
> |
| 10 |
> You might want to read up on "git commit --amend" and "git |
| 11 |
> rebase --interactive" ;-) |
| 12 |
|
| 13 |
Grrr, I hate Git. :) I will. |
| 14 |
|
| 15 |
> > punt table default-function-table, as the contents corresponds with |
| 16 |
> > default-phase-function-table |
| 17 |
> > Patches 08 and 21 |
| 18 |
> |
| 19 |
> These are technically separate concepts - there could conceivable be |
| 20 |
> an EAPI that has default_ functions but not default itself. On the |
| 21 |
> other hand, it's not really a big deal, and easy to reverse this |
| 22 |
> change if necessary (probably quite unlikely anyway). |
| 23 |
|
| 24 |
It is a current snapshot, so at the moment we have doubled information |
| 25 |
where not necessary. |
| 26 |
|
| 27 |
> > Generate date on titlepage from last commit |
| 28 |
> > Patch 11 |
| 29 |
> |
| 30 |
> This fails if it's not built from a git working tree, as happens with |
| 31 |
> git.eclass and pms-99999999.ebuild, and also any snapshot that anyone |
| 32 |
> may or may not want to distribute in future. |
| 33 |
|
| 34 |
A check for an empty \VCDateISO could be made and set it to \today (or |
| 35 |
whatever). Anyway, having the same date on the same (content-wise) |
| 36 |
PMS, generated on different machines is nice. |
| 37 |
|
| 38 |
V-Li |
| 39 |
|
| 40 |
-- |
| 41 |
Christian Faulhammer, Gentoo Lisp project |
| 42 |
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode |
| 43 |
|
| 44 |
<URL:http://www.faulhammer.org/> |
Archives