Gentoo Logo
Gentoo Spaceship

Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-pms
Lists: gentoo-pms: < Prev By Thread Next > < Prev By Date Next >
To: gentoo-pms@g.o
From: David Leverton <levertond@...>
Subject: Re: Some improvements
Date: Wed, 18 Feb 2009 18:54:49 +0000
On Wednesday 18 February 2009 16:53:43 Christian Faulhammer wrote:
> Hi,
> another round for my patch burst.  Comment, apply or die.

You might want to read up on "git commit --amend" and "git 
rebase --interactive" ;-)

> punt table default-function-table, as the contents corresponds with
> default-phase-function-table
> Patches 08 and 21

These are technically separate concepts - there could conceivable be an EAPI 
that has default_ functions but not default itself.  On the other hand, it's 
not really a big deal, and easy to reverse this change if necessary (probably 
quite unlikely anyway).

> Generate date on titlepage from last commit
> Patch 11

This fails if it's not built from a git working tree, as happens with 
git.eclass and pms-99999999.ebuild, and also any snapshot that anyone may or 
may not want to distribute in future.

Everything else seems OK to me.

Re: Some improvements
-- Christian Faulhammer
Some improvements
-- Christian Faulhammer
Lists: gentoo-pms: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Some improvements
Next by thread:
Re: Some improvements
Previous by date:
Some improvements
Next by date:
Re: Some improvements

Updated Jul 18, 2012

Summary: Archive of the gentoo-pms mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.