Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-pms
Navigation:
Lists: gentoo-pms: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-pms@g.o
From: Michael Orlitzky <michael@...>
Subject: Re: apply_user_patches
Date: Mon, 07 May 2012 12:19:40 -0400
On 05/07/12 11:17, Ulrich Mueller wrote:
> 
> After all, this functionality is just a stop-gap measure for users to
> apply quick bug fixes, so I don't expect that it will be used very
> often. Even fewer cases will require that eautoreconf is called. Do we
> really want to force developers to put this function call into every
> ebuild? That would be out of proportion, IMHO.

Only the ebuilds that override src_prepare (which is a lot).

The argument on -dev was that we could get 80% of the benefit for 0% of
the effort by just ignoring the issue. There's a trade-off, but 80%
isn't all that great (considering of course that all of these numbers
are made up).

Can that be increased to, say, 99% without any extra effort?

Are there easy heuristics to determine whether or not user patches
require eautoreconf? For example, if the patches fail at the beginning
of src_prepare, and the ebuild calls eautoreconf, that's a good
indication that we should call eautoreconf after the user patches are
applied (at the end of src_prepare).

Lacking a better way, though, I think requiring the developer to apply
the patches in the right spot is the only way to ensure correctness.


Replies:
Re: apply_user_patches
-- Michał Górny
References:
EAPI 5 development branch
-- Ciaran McCreesh
apply_user_patches (was: EAPI 5 development branch)
-- Ulrich Mueller
Re: apply_user_patches (was: EAPI 5 development branch)
-- Ciaran McCreesh
Re: apply_user_patches (was: EAPI 5 development branch)
-- Ulrich Mueller
Navigation:
Lists: gentoo-pms: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: apply_user_patches (was: EAPI 5 development branch)
Next by thread:
Re: apply_user_patches
Previous by date:
Re: apply_user_patches (was: EAPI 5 development branch)
Next by date:
Re: apply_user_patches (was: EAPI 5 development branch)


Updated Jul 18, 2012

Summary: Archive of the gentoo-pms mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.